Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect user to proper settings page to change device name #312

Open
ManasC478 opened this issue Sep 3, 2024 · 0 comments
Open

Redirect user to proper settings page to change device name #312

ManasC478 opened this issue Sep 3, 2024 · 0 comments

Comments

@ManasC478
Copy link
Collaborator

Describe the bug
Bundleclient expects the Wifidirect name of the transports to start with 'ddd_'. Right now we are able to detect if the name starts with 'ddd_' and if it doesn't we are able to redirect the user to the right place in the settings to change the device's name.

The bug is that right now we are redirecting the user to only the device's 'About' settings to change the name.

For some android devices changing the device's name will also change the device's WifiDirect name. Note: these devices might also not allow users to change the WifiDirect name directly. So in this case redirecting user to the device's 'About' settings works fine.

However, with other devices the WifiDirect name and device name act separately. So with these phones redirecting to the 'About' settings doesn't help, and we need to instead redirect to the 'WifiDirect' settings.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the WifiDirect settings and change the name to something not starting with 'ddd_'
  2. In the transport app go to the 'Local Wifi' tab and it should display the 'Change Phone Name' button. Click on it.
  3. The button click should open the device's 'About' settings. There change the device name to start with 'ddd_' if it doesn't already
  4. Go back to transport's 'Local Wifi' tab. If it still shows that the error 'Phone name must start with ddd_', that means your device's WifiDirect name and device name are separate and we should really be redirecting you to the 'WifiDirect' settings

Expected behavior
The expectation is to redirect the user to the 'WifiDirect' settings or 'About' settings page depending on what type of android device they have. If their device's WifiDirect name and device name are separate, then we should redirect the user to the WifiDirect setting. If the names are synced, then we should redirect user's to the About setting.

Additional Notes
It isn't fully clear which models fall under which category but so far I have observed the following.

WifiDirect and About names are synced:
Samsung S24

WifiDirect and About names are separate:
Pixel 4a
Pixel 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant