Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIMBAD link #164

Open
kelle opened this issue Dec 8, 2023 · 8 comments
Open

Add SIMBAD link #164

kelle opened this issue Dec 8, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@kelle
Copy link
Contributor

kelle commented Dec 8, 2023

We should have a link to the SIMBAD entry for the source. Not sure which table or to make a new table.

@kelle
Copy link
Contributor Author

kelle commented Jan 3, 2024

Thoughts on this @Will-Cooper, @dr-rodriguez, @arjunsavel ? I think either a dedicated table or a column in the Sources table. What do y'all think?

@kelle
Copy link
Contributor Author

kelle commented Jan 3, 2024

It will be the most useful to have the link to Simbad displayed on the website somehow so we should do whatever makes that the easiest to implement.

@kelle kelle added the enhancement New feature or request label Jan 3, 2024
@Will-Cooper
Copy link
Member

How about a table of external links so like: ExternalLinks(sourcename, simbadurl, ultracoolsheeturl), then wherever else comes up in future?

@kelle
Copy link
Contributor Author

kelle commented Jan 4, 2024

Huh, interesting idea.

One thing tho: Ultracool sheet links to us, we don't link to it. At least, that's currently not the plan.

@arjunsavel
Copy link

We want to have a link, and not an identifier? Because another option could be to treat this like a DOI.

@dr-rodriguez
Copy link
Collaborator

I thought we were aiming for the source name to be SIMBAD-resolvable already? If so, there wouldn't be a need to store a URL in the database.
In a UI you could just have a link to https://simbad.u-strasbg.fr/simbad/sim-basic?Ident=source_id&submit=SIMBAD+search and replace source_id with the name and that should be good enough.

@kelle
Copy link
Contributor Author

kelle commented Jan 5, 2024

Oh, that's pretty smart!!

@kelle kelle transferred this issue from SIMPLE-AstroDB/SIMPLE-db Jan 23, 2024
@Will-Cooper
Copy link
Member

This can be a clickable button by the share button on the solo_results page

@Will-Cooper Will-Cooper self-assigned this Jan 23, 2024
@Will-Cooper Will-Cooper added low priority Not a current requirement web design Basic web design and minor CSS and removed low priority Not a current requirement web design Basic web design and minor CSS labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants