Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all SFDX Commands to SF Commands #3621

Closed
GeekStewie opened this issue Jul 17, 2023 · 11 comments · Fixed by #3844
Closed

Upgrade all SFDX Commands to SF Commands #3621

GeekStewie opened this issue Jul 17, 2023 · 11 comments · Fixed by #3844
Labels
enhancement Listed under "Changes" in the changelog wi-created This issue is represented by a Work Item

Comments

@GeekStewie
Copy link

Feature Type

I'm interested in functionality that solves a current problem or limitation in how CumulusCI works.

Does your feature request solve a current problem?

I noticed this in the SFDX update today:

IMPORTANT ANNOUNCEMENT, PLEASE READ: We no longer update sfdx (v7); the last stable version is 7.209.6. You can keep using sfdx (v7) if you want, but it won't contain new features or bug fixes. And we no longer update this page.

And looking at the installers, it now defaults to the SF CLI when you install via npm etc.

I know we have had warnings for a while now but looks like the move needs to happen to ensure we are not using unsupported CLIs

Describe the solution you'd like

Migrate all SFDX commands within CumulusCI to SF equivalents

Describe alternatives you've considered

No response

Additional context

No response

@GeekStewie GeekStewie added the enhancement Listed under "Changes" in the changelog label Jul 17, 2023
@jstvz jstvz added the wi-created This issue is represented by a Work Item label Jul 17, 2023
@jstvz
Copy link
Contributor

jstvz commented Jul 17, 2023

Initial work tracked in W-13772594.

@mattmartin26
Copy link

Would really appreciate an update on this, our CTO is considering moving away from CumulusCI depending on if/how soon CCI will transition from SFDX to SF.

@jlantz
Copy link
Contributor

jlantz commented Oct 19, 2023

I'm no longer part of the team, but I do want to clarify the message from @GeekStewie's original post. The deprecation message is that they are no longer maintaining the sfdx package itself. The new sf cli package continues to ship with sfdx though. They just don't want you to install the old sfdx package directly anymore. CumulusCI still works fine against the new sf cli installers since they include sfdx.

The warnings call out a few places where CumulusCI's code needs to be updated to use the new commands and environment variables. I'd love to see them gone to avoid this confusion, but I'm reassured knowing that Salesforce is actively using CumulusCI. The Architecture Decision Record (ADR) discussion for this is available at in PR #3630

CumulusCI is actively built against test projects via GitHub Actions including full packaged builds against a test project. Any failures would be pretty quickly detected by those builds.

@davisagli
Copy link
Contributor

@jlantz It looks like the Github Actions need to be updated to install sf rather than sfdx, though: https://github.com/SFDO-Tooling/CumulusCI/blob/main/.github/workflows/feature_test.yml#L77

@jlantz
Copy link
Contributor

jlantz commented Oct 19, 2023

@davisagli Great point. That's an easy PR that I'll put together shortly as an early warning system at least.

@jstvz
Copy link
Contributor

jstvz commented Oct 19, 2023

@mattmartin26 Thanks for flagging this. Here's a quick update on the SFDX to SF CLI transition:

  • We've started work to migrate SFDX commands in CumulusCI to SF. It's on our radar. For details, check out the discussion on the proposed ADR in ADR: Migrate from SFDX to SF CLI #3630 (feedback welcome).
  • As @jlantz mentioned, the new sf CLI still ships with sfdx, commands will still function as expected despite the warnings.
  • We're adjusting our GitHub Actions per @davisagli's spot, to reflect the ongoing changes.

@georgeslater
Copy link

The latest CLI release candidate's release notes states that the force:org:create command will stop working on November 6th, 2024. Is that something to be concerned about?

@ant-wtrog
Copy link

As of today all out GitHub actions are failing with:

Creating scratch org with command: sfdx force:org:create --json -f orgs/feature.json -w 120 -n --durationdays 1 -a 'Kaleido KONTAKTE NPC__feature' � Error: Failed to create scratch org: Did you mean force cmdt create? (Y/n) [25](https://github.com/ANT-Informatik/Kaleido.Kontakte.NPC/actions/runs/11718482005/job/32639874754#step:9:26)h › Warning: force org create is not a sf command. › Error: Run sf help force for a list of available commands.

We use current cci and current sf client:

npm install @salesforce/cli --global

python -m pip install -U pip
pip install cumulusci
CumulusCI version: 3.93.0

@liamcollerton-giveclarity

And as of today, I can't run any flow that creates a scratch org.

It gives the error

Error: Failed to create scratch org:
Did you mean force cmdt create? [2m(Y/n)[22m[40G
[?25h
» Warning: force org create is not a sf command.
» Error: Run sf help force for a list of available commands.

I see that the PR has been merged (#3829)

Hopefully the release is imminent.

@Julian88Tex
Copy link
Contributor

@jstvz I'm guessing you're already on this, but I just wanted to tag you since it sounds like a high-priority issue as of late.

@jstvz
Copy link
Contributor

jstvz commented Nov 12, 2024

Thanks, @Julian88Tex, it's a high-priority for us too. We are actively working on this and will cut a release as soon as it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Listed under "Changes" in the changelog wi-created This issue is represented by a Work Item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants