Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyed each blocks #202

Open
Slartibartfass2 opened this issue Feb 8, 2025 · 0 comments · May be fixed by #218
Open

Use keyed each blocks #202

Slartibartfass2 opened this issue Feb 8, 2025 · 0 comments · May be fixed by #218
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Slartibartfass2
Copy link
Contributor

Currently, we don't use keys for svelte each blocks. According to the docs, this is good because svelte can then diff the elements and reload the items correctly.
There's an ESLint rule for that: https://sveltejs.github.io/eslint-plugin-svelte/rules/require-each-key/
We should investigate why the rule doesn't apply and enforce this behavior.

@Slartibartfass2 Slartibartfass2 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 8, 2025
@Slartibartfass2 Slartibartfass2 self-assigned this Feb 18, 2025
@Slartibartfass2 Slartibartfass2 linked a pull request Feb 18, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant