Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time series rotate erro check #1

Open
cgoulet opened this issue Oct 30, 2018 · 1 comment
Open

Time series rotate erro check #1

cgoulet opened this issue Oct 30, 2018 · 1 comment
Assignees

Comments

@cgoulet
Copy link
Collaborator

cgoulet commented Oct 30, 2018

On line 724 of ts_library.py (rotation of time series, creation of rotation matrix).
we should check if angle =270 and not assume that if it's not 90, it's 270.
If it's not 90 or not 270, the process should stop and return an error. This is not a common case, but there are a few datasets with errors in the sensor orientations. This test would check for that.

@cgoulet cgoulet assigned cgoulet and fabiolsilva and unassigned cgoulet Oct 30, 2018
@Naeemkh
Copy link

Naeemkh commented Jul 16, 2020

@fabiolsilva @cgoulet Is this still an open issue? Could you please send me an example of datasets with errors in the sensor orientations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants