From 9c906d1debb84d442241c44799c87c97fac1eeb8 Mon Sep 17 00:00:00 2001
From: Alexander Gilin <alexander.gilin@sap.com>
Date: Sun, 21 Jul 2024 12:18:17 +0300
Subject: [PATCH] fix: remove show done message if no files are generated

---
 packages/backend/src/vscode-youi-events.ts | 6 +++++-
 packages/backend/src/yeomanui.ts           | 9 +++++++--
 packages/backend/test/yeomanui.spec.ts     | 2 +-
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/packages/backend/src/vscode-youi-events.ts b/packages/backend/src/vscode-youi-events.ts
index 3f10ad71..d798ff08 100644
--- a/packages/backend/src/vscode-youi-events.ts
+++ b/packages/backend/src/vscode-youi-events.ts
@@ -193,7 +193,9 @@ export class VSCodeYouiEvents implements YouiEvents {
       }
 
       const successInfoMessage = this.getSuccessInfoMessage(selectedWorkspace, type);
-      return vscode.window.showInformationMessage(successInfoMessage);
+      return successInfoMessage // show the message only if it is not empty
+        ? vscode.window.showInformationMessage(successInfoMessage)
+        : Promise.resolve();
     }
 
     return vscode.window.showErrorMessage(errorMmessage);
@@ -211,6 +213,8 @@ export class VSCodeYouiEvents implements YouiEvents {
       }
     } else if (type === "module") {
       successInfoMessage = this.messages.artifact_generated_module;
+    } else if (type === "") {
+      successInfoMessage = ""; // do not show information message
     }
     return successInfoMessage;
   }
diff --git a/packages/backend/src/yeomanui.ts b/packages/backend/src/yeomanui.ts
index 9a4b321f..edfdc1c6 100644
--- a/packages/backend/src/yeomanui.ts
+++ b/packages/backend/src/yeomanui.ts
@@ -414,6 +414,7 @@ export class YeomanUI {
     // All the paths here absolute normilized paths.
     const targetFolderPathBeforeGen: string = _.get(resourcesBeforeGen, "targetFolderPath");
     const targetFolderPathAfterGen: string = _.get(resourcesAfterGen, "targetFolderPath");
+    let hasNewDirs: boolean = true;
     if (targetFolderPathBeforeGen === targetFolderPathAfterGen) {
       const newDirs: string[] = _.difference(
         _.get(resourcesAfterGen, "childDirs"),
@@ -423,7 +424,10 @@ export class YeomanUI {
         // One folder added by generator and targetFolderPath/destinationRoot was not changed by generator.
         // ---> Fiori project generator flow.
         targetFolderPath = newDirs[0];
-      } //else { //_.size(newDirs) = 0 (0 folders) or _.size(newDirs) > 1 (5 folders)
+      } else if (_.size(newDirs) === 0) {
+        hasNewDirs = false;
+      }
+      //else { // _.size(newDirs) > 1 (5 folders)
       // We don't know what is the correct targetFolderPath ---> no buttons should be shown.
       // No folder added by generator ---> Fiori module generator flow.
       // Many folders added by generator --->
@@ -447,7 +451,8 @@ export class YeomanUI {
     const generatedTemplatePath = targetFolderPath ? targetFolderPath : targetFolderPathBeforeGen;
     this.logger.debug(`done running yeomanui! ${message} You can find it at ${generatedTemplatePath}`);
     AnalyticsWrapper.updateGeneratorEnded(generatorName);
-    this.youiEvents.doGeneratorDone(true, message, selectedWorkspace, type, targetFolderPath);
+    // when targetFolderPath is undefined and no files are generated, send type = '' to get the empty toast message
+    this.youiEvents.doGeneratorDone(true, message, selectedWorkspace, hasNewDirs ? type : "", targetFolderPath);
     this.setInitialProcessDir();
     this.flowState.resolve();
     this.generatorName = ""; // reset generator name
diff --git a/packages/backend/test/yeomanui.spec.ts b/packages/backend/test/yeomanui.spec.ts
index b2c0a803..7bc09b0d 100644
--- a/packages/backend/test/yeomanui.spec.ts
+++ b/packages/backend/test/yeomanui.spec.ts
@@ -1179,7 +1179,7 @@ describe("yeomanui unit test", () => {
           // eslint-disable-next-line @typescript-eslint/no-unused-vars
           _.get(yeomanUi, "uiOptions.messages.artifact_with_name_generated", (a: string) => "")("testGenName"),
           create_and_close,
-          "files",
+          "",
           null,
         ),
       ).to.be.true;