New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with bundling with some Paths #18

Open

bd82 opened this issue Feb 20, 2018 · 1 comment

Labels

bug

Member

bd82 commented Feb 20, 2018

"src/package.json" works.
"/user/ixxxxxx/workshop/feature/package.json" works

but "package.json"
or "./package.json" does not work

bd82 added the bug label

Member Author

bd82 commented Jul 4, 2018

I think we should only support absolute paths.
We recently encountered some issues with windows + webpack
that got resolved by using absolute paths.

It also looks like webpack expects absolute paths for many configuration options
https://webpack.js.org/configuration/watch/#windows-paths

There is very little benefit having a fancy API here that supports all kinds of path styles...
And a very big headache trying to resolve those issues.

We can also add a validation to ensure that the path passed is absolute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment