Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input]: Safari ValueStateMessage causes blur #7960

Closed
1 task done
JarrettChan opened this issue Dec 5, 2023 · 10 comments
Closed
1 task done

[Input]: Safari ValueStateMessage causes blur #7960

JarrettChan opened this issue Dec 5, 2023 · 10 comments

Comments

@JarrettChan
Copy link

JarrettChan commented Dec 5, 2023

Bug Description

When the Input ValueStateMessage is triggered by focusing the Input, it causes a blur and the ValueStateMessage is still visible.
This interrupts the usage as the Input is no longer focused.
The input still can be used because the ValueStateMessage is still open after the blur.

Affected Component

ui5-input

Expected Behaviour

ValueStateMessage should not cause blur when shown.

Isolated Example

No response

Steps to Reproduce

  1. Safari Version 17.1 (19616.2.9.11.7)
  2. https://sap.github.io/ui5-webcomponents/playground/?path=/story/main-input--value-state-message
  3. Tab into the input
    Observe: ValueStateMessage is visible, but focus was blurred
  4. Tab into the input again
    Observe: ValueStateMessage is visible and focus is in input

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.18.0, 1.19.1, 1.20.0

Browser

Safari

Operating System

No response

Additional Context

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@JarrettChan JarrettChan added the bug This issue is a bug in the code label Dec 5, 2023
@unazko unazko self-assigned this Dec 6, 2023
@unazko unazko added the TOPIC RL label Dec 6, 2023
@unazko
Copy link
Contributor

unazko commented Dec 6, 2023

Hello @SAP/ui5-webcomponents-topic-rl,

The value state popup appears for the input field:
image

Best regards,
Boyan

@unazko unazko removed their assignment Dec 6, 2023
@MapTo0
Copy link
Member

MapTo0 commented Dec 7, 2023

@SAP/ui5-webcomponents-topic-rd

The Popover has some issues with positioning: https://sap.github.io/ui5-webcomponents/playground/?path=/story/main-popover--basic

@MapTo0 MapTo0 added TOPIC RD and removed TOPIC RL labels Dec 7, 2023
@MapTo0
Copy link
Member

MapTo0 commented Dec 7, 2023

Possible regression: #7870

@petyabegovska
Copy link
Collaborator

Hello, the issue looks more general as the popover is not visible or wrongly positioned in all the inputs on Safari- you can check also ui5-combobox and ui5-select in Storybook: https://sap.github.io/ui5-webcomponents/nightly/playground/?path=/docs/main-combo-box--docs. That's why I increase the priority to high.

Best regards,
Petya

@ilhan007
Copy link
Member

ilhan007 commented Dec 9, 2023

Hello @JarrettChan can you retest, we have merged and released a fix with 1.20.1
https://sap.github.io/ui5-webcomponents/nightly/playground/?path=/story/main-input--value-state-message

@JarrettChan
Copy link
Author

JarrettChan commented Dec 11, 2023

Hi @ilhan007,
The popover position looks good, but that is not my issue.
The issue I reported is that when you focus an Input with ValueStateMessage in Safari, it immediately blurs.
This is not fixed.

Typing into the storybook Input can obviously show the issue as it shows error state after typing and blurs.

@MapTo0
Copy link
Member

MapTo0 commented Dec 12, 2023

Snippet to reproduce this with a popover only:

<input id="opener" />
<ui5-popover id="popup" _disable-initial-focus></ui5-popover>

<script>
  const opener = document.getElementById("opener");

  opener.addEventListener("focusin", event => {
    document.getElementById("popup").showAt(opener, true);
  });

  opener.addEventListener("blur", event => {
    console.log("=========== BLUR =========");
  });
</script>

@MapTo0 MapTo0 removed the TOPIC RL label Dec 12, 2023
@georgimkv georgimkv self-assigned this Dec 13, 2023
@georgimkv georgimkv removed their assignment Dec 22, 2023
@kskondov kskondov self-assigned this Jan 24, 2024
@kskondov
Copy link
Contributor

Hello @JarrettChan and @MapTo0 as I was not able to reproduce this issue can you confirm that it is still reproducible on your side?

Best Regards

@kskondov kskondov added bug This issue is a bug in the code and removed bug This issue is a bug in the code labels Jan 24, 2024
@MapTo0
Copy link
Member

MapTo0 commented Jan 24, 2024

I am not able to reproduce it as well. Maybe Apple did some changes @JarrettChan how about you?

@kskondov
Copy link
Contributor

After feedback from @MapTo0 and @JarrettChan I am closing this issue as not reproducible

@kskondov kskondov removed author action bug This issue is a bug in the code labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

7 participants