diff --git a/packages/main/src/Menu.hbs b/packages/main/src/Menu.hbs index 7f2f39a2cd5a..8d02d28874ab 100644 --- a/packages/main/src/Menu.hbs +++ b/packages/main/src/Menu.hbs @@ -7,7 +7,6 @@ .opener={{opener}} ?open={{open}} prevent-initial-focus - prevent-focus-restore hide-arrow allow-target-overlap @ui5-before-open={{_beforePopoverOpen}} diff --git a/packages/main/src/Menu.ts b/packages/main/src/Menu.ts index f088575b71fc..e728228c9953 100644 --- a/packages/main/src/Menu.ts +++ b/packages/main/src/Menu.ts @@ -22,7 +22,6 @@ import ResponsivePopover from "./ResponsivePopover.js"; import type { ResponsivePopoverBeforeCloseEventDetail } from "./ResponsivePopover.js"; import Button from "./Button.js"; import List from "./List.js"; -import Icon from "./Icon.js"; import BusyIndicator from "./BusyIndicator.js"; import MenuItem from "./MenuItem.js"; import MenuSeparator from "./MenuSeparator.js"; @@ -104,7 +103,6 @@ type MenuBeforeCloseEventDetail = { escPressed: boolean }; List, MenuItem, MenuSeparator, - Icon, BusyIndicator, ], }) @@ -387,7 +385,6 @@ class Menu extends UI5Element { } _afterPopoverOpen() { - this.open = true; this._menuItems[0]?.focus(); this.fireEvent("open", {}, false, true); } diff --git a/packages/main/src/MenuItem.ts b/packages/main/src/MenuItem.ts index eb6480c0d086..144df13062b4 100644 --- a/packages/main/src/MenuItem.ts +++ b/packages/main/src/MenuItem.ts @@ -189,7 +189,7 @@ class MenuItem extends ListItem implements IMenuItem { } get hasSubmenu() { - return !!(this.items.length || this.loading); + return !!(this.items.length || this.loading) && !this.disabled; } get hasEndContent() { @@ -296,6 +296,9 @@ class MenuItem extends ListItem implements IMenuItem { this.selected = false; if (e.detail.escPressed) { this.focus(); + if (isPhone()) { + this.fireEvent("close-menu", {}); + } } } diff --git a/packages/main/test/pages/Menu.html b/packages/main/test/pages/Menu.html index 751d904366a6..fc4f1b4bd80b 100644 --- a/packages/main/test/pages/Menu.html +++ b/packages/main/test/pages/Menu.html @@ -16,7 +16,9 @@ Open Menu
- + + + @@ -85,10 +87,12 @@ - + + + @@ -102,7 +106,8 @@ - + +