From a5cfb8ece4e03553271a41700c59c29d82952c76 Mon Sep 17 00:00:00 2001 From: Max Reichmann Date: Thu, 1 Aug 2024 16:37:25 +0200 Subject: [PATCH] [INTERNAL] Refactor in fav. of ES2019 --- lib/lbt/analyzer/XMLTemplateAnalyzer.js | 3 +-- lib/lbt/bundle/Builder.js | 3 +-- lib/lbt/resources/ResourceCollector.js | 3 +-- lib/processors/manifestEnhancer.js | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/lbt/analyzer/XMLTemplateAnalyzer.js b/lib/lbt/analyzer/XMLTemplateAnalyzer.js index ab404d008..e6023e019 100644 --- a/lib/lbt/analyzer/XMLTemplateAnalyzer.js +++ b/lib/lbt/analyzer/XMLTemplateAnalyzer.js @@ -402,8 +402,7 @@ class XMLTemplateAnalyzer { } } } - // eslint-disable-next-line no-unused-vars - } catch (err) { + } catch { // ignore missing resources // console.warn( "node not found %s", moduleName); } diff --git a/lib/lbt/bundle/Builder.js b/lib/lbt/bundle/Builder.js index d6cc4bb70..5f917e8b9 100644 --- a/lib/lbt/bundle/Builder.js +++ b/lib/lbt/bundle/Builder.js @@ -636,8 +636,7 @@ class BundleBuilder { let resource = null; try { resource = await this.pool.findResourceWithInfo(module); - // eslint-disable-next-line no-unused-vars - } catch (e) { + } catch { log.error(` couldn't find ${module}`); } diff --git a/lib/lbt/resources/ResourceCollector.js b/lib/lbt/resources/ResourceCollector.js index f9443e8bb..927ce2dd1 100644 --- a/lib/lbt/resources/ResourceCollector.js +++ b/lib/lbt/resources/ResourceCollector.js @@ -140,8 +140,7 @@ class ResourceCollector { let subModuleInfo; try { subModuleInfo = await this._pool.getModuleInfo(subModule); - // eslint-disable-next-line no-unused-vars - } catch (err) { + } catch { log.verbose(` Missing submodule ${subModule} included by ${moduleInfo.name}`); } if (subModuleInfo) { diff --git a/lib/processors/manifestEnhancer.js b/lib/processors/manifestEnhancer.js index 0d81f5286..11edb3f8a 100644 --- a/lib/processors/manifestEnhancer.js +++ b/lib/processors/manifestEnhancer.js @@ -15,8 +15,7 @@ function isAbsoluteUrl(url) { const parsedUrl = new URL(url); // URL with ui5 protocol shouldn't be treated as absolute URL and will be handled separately return parsedUrl.protocol !== "ui5:"; - // eslint-disable-next-line no-unused-vars - } catch (err) { + } catch { // URL constructor without base requires absolute URL and throws an error for relative URLs return false; }