You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should use feat: prefix or better fix: in the commit title so that the changelog is generated correctly when we do a release. We should move or drop the "(a11y)" part from the prefix. Some information on this here.
In the commit message, we use Closes: CXSPA-xxxx and link it to the ticket in JIRA.
uroslates
changed the title
feat(a11y): add * to required billing address form fields on checkout pyament details
fix: add * to required billing address form fields on checkout payment details
Oct 16, 2024
@uroslates LGTM, just one last adjustment please, this other PR #19327 adds an ARIA attribute to asterisks, can you please sync up with @StanislavSukhanov and update your asterisks to include those attributes as well.
@uroslates LGTM, just one last adjustment please, this other PR #19327 adds an ARIA attribute to asterisks, can you please sync up with @StanislavSukhanov and update your asterisks to include those attributes as well.
Applied the requested change - * are now not read by the Readers.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.