Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support separate annotation files #215

Open
phanak-sap opened this issue Jun 8, 2022 · 2 comments
Open

feature: support separate annotation files #215

phanak-sap opened this issue Jun 8, 2022 · 2 comments
Labels
enhancement New feature or request V4 OData V4

Comments

@phanak-sap
Copy link
Contributor

It possible, that not everything is in $metadata file. Sometimes, additional annotations come as separate request to different, unknown URL, (e.g. SAP fiori app in RAP framework).

refer to odata-library:

Example:

  • Fiori app Profit Center Changelog.
  • URL: /IWFND/CATALOGSERVICE;v=2/Annotations(TechnicalName='FAC_PROFIT_CENTER_CHANGLOG_VAN',Version='0001')/$value/?sap-language=EN&sap-client=715";
@phanak-sap phanak-sap added the enhancement New feature or request label Jun 8, 2022
@jfilak
Copy link
Contributor

jfilak commented Jul 27, 2022

Good idea. Do that.

@phanak-sap phanak-sap added the V4 OData V4 label Oct 27, 2022
@phanak-sap
Copy link
Contributor Author

Notes:

  • There may be multiple external annotations URLs, odata-library just expects one, since that is the SAP systems default.

  • This seems on first glance that is logical that V2 odata service will have V2 external annotations (which is checked in pyodata during metadata parsing), but actually V2 services for fiori apps have V4 external annotations, just that they are backward compatible in this instance, they are applied to V2 metadata; but current pyodata logic would not recognize V4 xml declarations as valid.

  • This enhancement should actually be considered a subtask for V4 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request V4 OData V4
Projects
None yet
Development

No branches or pull requests

2 participants