Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning function directly to "renderer" should no longer be encouraged #33

Closed
boghyon opened this issue Mar 10, 2020 · 3 comments
Closed

Comments

@boghyon
Copy link
Contributor

boghyon commented Mar 10, 2020

Specifying the renderer without apiVersion: 2 (e.g. renderer: <fn>) causes falling back to the legacy string-based rendering even with semantic rendering APIs, i.e. no DOM-patching can be performed.

And according to SAP/openui5#2822, there won't be any implicit setting of the flag either.

Topics that mention renderer: <fn> should be all updated; informing that renderer: <fn> should no longer be used and that apiVersion: 2 should be explicitly set. E.g.:

renderer: function(oRM, oControl) {/*...*/}
renderer: {
  apiVersion: 2,
  render: function(oRM, oControl) {
    // ...
  }
}
@Thodd
Copy link

Thodd commented Sep 7, 2021

Hi @boghyon,

sorry this issue got lost somehow.
I'm adapting some parts of the Renderer documentation right now, so I adapt it where I find this inconsistency.

Additionally I'll see that I make a backlog item or something for a broader cleanup.
I guess there are a couple of occurrences... I haven't grep'ed yet.

BR,
Thorsten

@flovogt
Copy link
Member

flovogt commented Jan 25, 2022

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident 2280031655. The status of the issue will be updated here in GitHub.

@Thodd
Copy link

Thodd commented Feb 2, 2022

Hi @boghyon & @flovogt,

I'll close this issue with a reference on #17.

Initially I thought I could just replace the usage of the "renderer" function, but that's to superficial.
The goal should be to have more general rework of the rendering topic. So I'll drop this bandaid for now
and have created an internal backlog item based on @boghyon initial proposal in issue 17.
That should also cover the removal of renderer function usage in favor of an in-place object syntax.

PS: Backlog item id is CPOUI5FRAMEWORK-343 ;)

BR,
Thorsten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants