Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE - odata-service-inquirer: Add Cloud Foundry Abap service support for Business Application Studio #2866

Closed
3 tasks
IainSAP opened this issue Feb 5, 2025 · 0 comments
Closed
3 tasks

FEATURE - odata-service-inquirer: Add Cloud Foundry Abap service support for Business Application Studio #2866

IainSAP opened this issue Feb 5, 2025 · 0 comments
Assignees
@IainSAP
Labels
odata-service-inquirer @sap-ux/odata-service-inquirer

Comments

@IainSAP
Copy link
Contributor

IainSAP commented Feb 5, 2025 •
edited
Loading

Description

Add support to query CF for Abap services on BAS. This requires an additional step of creating a destination to allow access from deployed apps and during generation from BAS to retrieve services. The newly added @sap-ux/btp-utils API: createOAuth2UserTokenExchangeDest can be used for this purpose.

Technical Design

Updates @sap-ux/odata-service-inquirer to add handling of the existing but not yet implemented BAS specific system selection option "Cloud Foundry ABAP environment on SAP Business Technology Platform". The feature can be implemented by using and modifying the existing implemented prompt functionality combining:

return [
        ...getCFDiscoverPrompts(connectionValidator, cfAbapBasPromptNamespace, promptOptions?.requiredOdataVersion),
        ...getSystemServiceQuestion(connectionValidator, cfAbapBasPromptNamespace, promptOptions)
    ];

Acceptance Criteria

GivenWhenThen format (https://martinfowler.com/bliki/GivenWhenThen.html)

Given I have a ...
when I execute ...
then ... will happen.

Notes

Tasks

  • Unit Tests added
  • Test Cases defined
@IainSAP IainSAP added the odata-service-inquirer @sap-ux/odata-service-inquirer label Feb 5, 2025
@IainSAP IainSAP self-assigned this Feb 5, 2025
IainSAP added a commit that referenced this issue Feb 5, 2025
@IainSAP
feat(odata-service-inquirer): Adds CF disco on BAS
34f9fae 
#2866
@IainSAP IainSAP mentioned this issue Feb 5, 2025
Merged
IainSAP added a commit that referenced this issue Feb 5, 2025
@IainSAP @github-actions
feat(odata-service-inquirer): #2866 - Adds cf bas prompts (#2867)
65f15d9 
* Updates API `generateOAuth2UserTokenExchangeDestination` for UAA param

#2855

* Fix test file

* Adds cset

* Fix incorrect uaa mapping, add test to cover

* feat(odata-service-inquirer): Adds CF disco on BAS

#2866

* Linting auto fix commit

* Adds new cset

* Pass correct resolved url credentials

* Create shared type `ValidationResult`

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
devinea added a commit that referenced this issue Feb 7, 2025
@devinea
Merge remote-tracking branch 'origin/main' into ff_tests_writer
bfc72ea 
* origin/main: (43 commits)
  chore: apply latest changesets
  feat(abap-deploy-config-inq): option for createDuringDeploy list item (#2864)
  chore: apply latest changesets
  feat(preview-middleware):add support for type component (#2872)
  chore: apply latest changesets
  feat: introduce ADP FLP config generator (#2730)
  fix(cf-gen): fix unstable windows test (#2876)
  chore: apply latest changesets
  fix: project access dependency (#2875)
  chore: apply latest changesets
  feat(odata-service-inquirer): #2866 - Adds cf bas prompts (#2867)
  chore: apply latest changesets
  feat: add context menu for outline in cpe (#2847)
  chore: apply latest changesets
  feat(cf-gen): adds new sub generator to `@sap-ux/cf-deploy-config-sub-generator` (#2844)
  chore: apply latest changesets
  fix: Default model naming (#2862)
  chore: apply latest changesets
  correct command type for add annotation file (#2839)
  chore: apply latest changesets
  ...
@IainSAP IainSAP closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IainSAP IainSAP

Labels
odata-service-inquirer @sap-ux/odata-service-inquirer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IainSAP