Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Proper check for Cloud Abap Systems #2704

Open
3 tasks
GDamyanov opened this issue Dec 16, 2024 · 0 comments
Open
3 tasks

FEATURE - Proper check for Cloud Abap Systems #2704

GDamyanov opened this issue Dec 16, 2024 · 0 comments
Assignees

Comments

@GDamyanov
Copy link
Contributor

As a persona,
I want to have proper check if ABAP system is cloud or not,
so that I I can finish my business logic

Description

Currently there is a method "@sap-ux/axios-extension" called "isS4Cloud" which does not work properly for internal cloud systems. After discussions we took on a decision its name to be changed to "isAbapCloud" and to rely only to two of the properties from atoSettings:

  • atoSettings.tenantType === ‘CUSTOMER' &&
  • atoSettings.operationsType === 'C'

Technical Design

@sap-ux/axios-extension module should be enhanced with the needed changes

Acceptance Criteria

GivenWhenThen format (https://martinfowler.com/bliki/GivenWhenThen.html)

Given I have a system
when I execute "isS4Cloud" method from axios-extension
then I should know whether ABAP system is cloud or not.

Notes

Tasks

  • Unit Tests added
  • Test Cases defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant