Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Enhance extracted FLP prompts to support ADP scenario #2605

Open
3 tasks
nikmace opened this issue Nov 21, 2024 · 0 comments
Open
3 tasks

FEATURE - Enhance extracted FLP prompts to support ADP scenario #2605

nikmace opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
create @sap-ux/create feature New feature or request flp-config-inquirer @sap-ux/flp-config-inquirer

Comments

@nikmace
Copy link
Contributor

nikmace commented Nov 21, 2024

As a developer,
I want to be able to configure Fiori Launchpad config in Adaptation Project scenario,
so that I can see my ADP application in the Fiori launchpad after the project has been deployed

Description

What is the high-level purpose and value of the feature? The description should ensure that anyone reading understands what it is doing (at a high level) and most importantly why.

Currently, FT offers a different FLP configuration than the ADP. I want to have the same experience when using Adaptation Project - the ability to use the same tool to create FLP configurations for adaptation projects.

I want to have the following changes in prompting, when this tool is working for ADP:

  • the S/4 flp configuration question in the beginning should NOT be shown
  • another question under the visible 4 textboxes should be shown - the existing one for Parameters in our current ADP generation process for S/4 HANA Cloud.

Add new inbound.
Case 1. manifest.appdescr_variant HAS NO FLP Configuration:
a. If the base application has inbounds, then show the inbounds list input with all available inbounds plus we show the 4 prompts as Fiori do (Semantic Object, Action, Title, Subtitle).

b. Base application has no inbounds, then we show the 4 prompts as Fiori do (Semantic Object, Action, Title, Subtitle) and the parameters question. After that we create a "dummy" inbound which is "<app.id>.InboundID".

In YUI at the end of the 5 questions a new question should be shown with the following details (in YUI):

  • type: Radio Button with Yes and No answers
  • text: "Do you want to add or edit another inbound?" with tooltip text: "If you select Yes and press Finish the current one will be saved and you will have the opportunity to add another one"
  • When I press Finish if I have selected Yes on the radio button, the "Add Inbound" change should be saved and the tool should be relaunched again. If I have selected NO, just the change should be saved.

Technical Design

What modules need to be created or enhanced?
How would the functionality be exposed and how can it be consumed?

Acceptance Criteria

GivenWhenThen format (https://martinfowler.com/bliki/GivenWhenThen.html)

Given I have a ADP
when I execute add navigation-config command
then an FLP configuration is added to my project (manifest.appdescr_variant).

Notes

Tasks

  • Unit Tests added
  • Test Cases defined
@nikmace nikmace added feature New feature or request create @sap-ux/create flp-config-inquirer @sap-ux/flp-config-inquirer labels Nov 21, 2024
@nikmace nikmace self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create @sap-ux/create feature New feature or request flp-config-inquirer @sap-ux/flp-config-inquirer
Projects
None yet
Development

No branches or pull requests

1 participant