Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - unable to deploy to onpremise destination when webideusage is configured as odata_gen #2272

Open
3 tasks
longieirl opened this issue Aug 22, 2024 · 0 comments
Labels
bug Something isn't working deploy deploy-tooling @sap-ux/deploy-tooling

Comments

@longieirl
Copy link
Contributor

Description

When deploying to a SAP BTP destination the following error is thrown;

error builder:custom deploy-to-abap Cannot read properties of undefined (reading 'bind')
Command deploy failed with error : Cannot read properties of undefined (reading 'bind')

The reason is due to the SAP BTP destination configured with odata_gen which causes the following method to return false;

https://github.com/SAP/open-ux-tools/blob/main/packages/axios-extension/src/factory.ts#L209

Sample destination;

    {
        "Type": "HTTP",
        "HTML5.DynamicDestination": "true",
        "Authentication": "BasicAuthentication",
        "WebIDEUsage": "odata_gen",
        "Name": "MYTESTDEST",
        "WebIDEEnabled": "true",
        "ProxyType": "OnPremise",
        "WebIDESystem": "SAP",
        "Host": "http://billing.hana.ondemand.com:50001"
    }

Sample ui5-deploy;

# yaml-language-server: $schema=https://sap.github.io/ui5-tooling/schema/ui5.yaml.json

specVersion: "3.1"
metadata:
  name: hansenpoc02
type: application
builder:
  resources:
    excludes:
      - /test/**
      - /localService/**
  customTasks:
    - name: deploy-to-abap
      afterTask: generateCachebusterInfo
      configuration:
        log: 4
        verbose: true
        test: true
        createTransport: true
        target:
          destination: MYTESTDEST
          url: http://billing.hana.ondemand.com:50001       
        app:
          name: ztest
          description: Test
          package: testpackage
          transport: testpackage
        exclude:
          - /test/

To unblock the deployment step, change WebIDEUsage to odata_abap.

Steps to Reproduce

Steps to reproduce the behaviour:

  1. Create a destination with WebIDEUsage configured as odata_gen
  2. Create any type of project
  3. Ensure to add ABAP deployment
  4. Run deployment step npm run deploy

Expected results

To deploy correctly

Actual results

Deployment fails and there is no explanation.

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

@longieirl longieirl added bug Something isn't working deploy-tooling @sap-ux/deploy-tooling deploy labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deploy deploy-tooling @sap-ux/deploy-tooling
Projects
None yet
Development

No branches or pull requests

1 participant