From 073ce45cb45e103b4bd6e2509829f56f5d0c7c75 Mon Sep 17 00:00:00 2001 From: Oliver Feldmann Date: Thu, 27 Jul 2023 18:06:59 +0200 Subject: [PATCH] Fix docker arg --- .github/workflows/lint.yml | 3 ++- Dockerfile | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index f8a3736..ab2c2bd 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -14,4 +14,5 @@ jobs: # https://github.com/hadolint/hadolint/wiki/DL3018 # https://github.com/hadolint/hadolint/wiki/DL3015 # https://github.com/hadolint/hadolint/wiki/DL3006 Make it work to build multiple node versions in one dockerfile via matrix build - args: --ignore DL3008 --ignore DL3013 --ignore DL3016 --ignore DL3018 --ignore DL3015 --ignore DL3006 + # https://github.com/koalaman/shellcheck/wiki/SC2086 If we quote the JAVA_VERSION the ARG is not used + args: --ignore DL3008 --ignore DL3013 --ignore DL3016 --ignore DL3018 --ignore DL3015 --ignore DL3006 --ignore SC2086 diff --git a/Dockerfile b/Dockerfile index 8d93379..cc2fbeb 100644 --- a/Dockerfile +++ b/Dockerfile @@ -4,7 +4,7 @@ ARG JAVA_VERSION FROM node:$BASE_IMAGE_TAG RUN apt-get update && \ - apt-get install -y chromium firefox-esr xvfb libxi6 libgbm1 libgconf-2-4 openjdk-"${JAVA_VERSION}"-jre && \ + apt-get install -y chromium firefox-esr xvfb libxi6 libgbm1 libgconf-2-4 openjdk-$JAVA_VERSION-jre && \ rm -rf /var/lib/apt/lists/* /var/cache/apt/* && \ ln -s /usr/bin/chromium /usr/bin/google-chrome