Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdi5 script not present in the main/default branch #39

Open
srinikitha09 opened this issue Apr 16, 2024 · 12 comments
Open

wdi5 script not present in the main/default branch #39

srinikitha09 opened this issue Apr 16, 2024 · 12 comments

Comments

@srinikitha09
Copy link
Collaborator

Hi,
Basically, this application is a reference to run wdi5 tests on cap applications, but the main default branch does not contain the script to run wdi5 tests. May be it makes sense to merge the changes from solution branch to main branch so that it would be easier for the users who are ending up in search of configuring wdi5 test suite setup to their applications.

Thanks and Regards,
Nikitha

@srinikitha09 srinikitha09 changed the title wdi5 script not present in the main branch wdi5 script not present in the main/default branch Apr 16, 2024
@Siolto
Copy link
Contributor

Siolto commented Apr 16, 2024

Hi @srinikitha09,

this repository is part of the official wdi5 tutorial. The main branch does not include the wdi5 tests because they will create and run the tests during the tutorial.

@srinikitha09
Copy link
Collaborator Author

Hi @Siolto ,
Thanks for the quick reply. Now I get it, but that tutorial is bit outdated as if the user runs command wdi5@latest it uses wdi5 v2 but tutorial points to v1. Do you think it is still fine or we need to update the tutorial asap?

@Siolto
Copy link
Contributor

Siolto commented Apr 16, 2024

It wouldn't be a bad idea to update the tutorial or the repository. There is probably a lot that has changed since the tutorial was created. But I hope the tutorial still works even with the newest version.

If it is really needed to update the tutorial the question would be who would have the time or resources to update the tutorial?

@srinikitha09
Copy link
Collaborator Author

srinikitha09 commented Apr 16, 2024

@kaylinche @o-liver do you have any thoughts on this?

Actually, I was contacted by an internal SAP colleague to setup wdi5 for their project. I have pointed out them to this repo, but then I lately realized that this application is outdated.

@o-liver
Copy link
Collaborator

o-liver commented Apr 16, 2024

Hi @Siolto , Thanks for the quick reply. Now I get it, but that tutorial is bit outdated as if the user runs command wdi5@latest it uses wdi5 v2 but tutorial points to v1. Do you think it is still fine or we need to update the tutorial asap?

Could we change the tutorial to not do a wdi5@latest, but instead wdi5@^1.x.x? Then the rest of the tutorial can stay as is and also the sample application can stay as it is.

@srinikitha09
Copy link
Collaborator Author

Hi @Siolto , Thanks for the quick reply. Now I get it, but that tutorial is bit outdated as if the user runs command wdi5@latest it uses wdi5 v2 but tutorial points to v1. Do you think it is still fine or we need to update the tutorial asap?

Could we change the tutorial to not do a wdi5@latest, but instead wdi5@^1.x.x? Then the rest of the tutorial can stay as is and also the sample application can stay as it is.

Yes, I think that would be a temporary solution.

@Siolto
Copy link
Contributor

Siolto commented Apr 17, 2024

Does the tutorial currently not work with wdi5@latest? If yes, then we could go to the latest wdi5@^1.x.x. If it still runs fine I would leave it as it is

@srinikitha09
Copy link
Collaborator Author

Does the tutorial currently not work with wdi5@latest? If yes, then we could go to the latest wdi5@^1.x.x. If it still runs fine I would leave it as it is

I will test it and get back to you soon!

@Siolto
Copy link
Contributor

Siolto commented Apr 17, 2024

Thanks a lot! I am also not happy that no one really has the ownership/responsibility for this tutorial and repository to keep it up to date 😢 . But I guess this discussion has already been held several times.

@srinikitha09
Copy link
Collaborator Author

srinikitha09 commented Apr 17, 2024

I see the following error when I run the wdi5 command:

wdi5

@srinikitha09
Copy link
Collaborator Author

I really wonder if this tutorial ever worked in a straightforward way without any adaptations.

Atleast as far as I noticed, this tutorial does not work out of the box with wdi5 v2. I am also not sure if npm init wdi5@v1 would work.

@Siolto
Copy link
Contributor

Siolto commented Apr 17, 2024

I will have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants