Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc issue] Missing modification in Step 4: Two-Way Data Binding for file index.html #94

Closed
hhelibeb opened this issue Nov 15, 2023 · 3 comments
Assignees
Labels
contribution Valuable Contribution size/l Requires large effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.

Comments

@hhelibeb
Copy link
Contributor

Issue description

I discovered an omission in Tutorial Step 4: Two-Way Data Binding. There is an essential modification in the index.html file, the attribute data-sap-ui-resourceroots , which is present in the provided code sample but not described in the tutorial text. This omission leads to exception when following the code provided in the tutorial.
There is no data-sap-ui-resourceroots in step 3,
图片
but we can find it in step 4,
图片

Please consider updating the tutorial to include the missing modification found in the index.html file.

Feedback Type (Optional)

content gaps

Page Title on SAP Help Portal (prefilled)

Step 4: Two-Way Data Binding

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/c72b922fdb59422496661000165d7ff1

@KlattG KlattG self-assigned this Nov 15, 2023
@OlMue OlMue added contribution Valuable Contribution type/content-gaps Something essential is missing in the documentation. labels Nov 22, 2023
Copy link

sap-doc-bot bot commented Nov 22, 2023

Thank you for your valuable feedback contribution, @hhelibeb! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@KlattG KlattG added in-discussion This item is being discussed internally size/l Requires large effort to get changed. follow-up-with/dev Clarification with development needed. follow-up-with/po Clarification with product owner needed. ua-review Under review by the UA team. and removed follow-up-with/dev Clarification with development needed. labels Dec 19, 2023
@KlattG
Copy link
Contributor

KlattG commented Dec 19, 2023

Hi @hhelibeb , thanks for pointing this out. We agree that the description should be improved and decided to fix the issue as part of an upcoming general revision of the Data Binding tutorial and sample code.

We close this issue for the time being and let you know once we've revised the tutorial.

@KlattG KlattG closed this as completed Dec 19, 2023
@KlattG KlattG removed in-discussion This item is being discussed internally ua-review Under review by the UA team. follow-up-with/po Clarification with product owner needed. labels Jan 15, 2024
@KlattG
Copy link
Contributor

KlattG commented Mar 26, 2024

Hi @hhelibeb , thanks again for your contribution. I just wanted to let you know that we've now revised the tutorial and fixed the issue as of UI5 1.122

@KlattG KlattG added type/examples-samples Related to existing examples/samples, or request for new examples/samples. and removed type/content-gaps Something essential is missing in the documentation. labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution size/l Requires large effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

No branches or pull requests

3 participants