Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Walkthrough Tutorial -> Step 9: Component Configuration -> webapp/Component.js: wrong bundle name #91

Closed
micbez opened this issue Nov 9, 2023 · 1 comment
Closed

Walkthrough Tutorial -> Step 9: Component Configuration -> webapp/Component.js: wrong bundle name #91

micbez opened this issue Nov 9, 2023 · 1 comment
Assignees
@KlattG
Labels
contribution Valuable Contribution follow-up-with/dev Clarification with development needed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.

Comments

@micbez
Copy link

micbez commented Nov 9, 2023 •
edited
Loading

Issue description

Hi colleagues,

I've realized small bug in Walkthrough exercise -> Step 9: Component Configuration -> webapp/Component.js. Here is defined bundle as "sap.ui.demo.walkthrough.i18n.i18n", but correct name is "ui5.walkthrough.i18n.i18n". Please double check my finding (e.g. with bundle from previous step = Step 8: Translatable Texts). And thank you for correction! :)

Kind regards,
Michal

P.S. I like this Walkthrough ;)
@KlattG KlattG self-assigned this Nov 9, 2023
@KlattG
Copy link
Contributor

KlattG commented Nov 9, 2023 •
edited
Loading

Hi @micbez , thanks for letting us know.
Issue will be fixed in one of the next patch sets / next release
Kind regards
Günter

@KlattG KlattG closed this as completed Nov 9, 2023
@OlMue OlMue added contribution Valuable Contribution follow-up-with/dev Clarification with development needed. type/examples-samples Related to existing examples/samples, or request for new examples/samples. labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KlattG KlattG

Labels
contribution Valuable Contribution follow-up-with/dev Clarification with development needed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OlMue @KlattG @micbez