Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough Step 28 not complete #9

Closed
thunermay opened this issue Oct 28, 2022 · 4 comments
Closed

Walkthrough Step 28 not complete #9

thunermay opened this issue Oct 28, 2022 · 4 comments
Assignees
Labels
contribution Valuable Contribution mission-award SAP Community mission award type/content-gaps Something essential is missing in the documentation. ua-review Under review by the UA team.

Comments

@thunermay
Copy link

When programming the Walkthrough Step 28, there is something missing.
In the NavigationJourney.js there are 4 steps:

  • Given: iStartMyUiComponent
  • When: onTheAppPage.iPressSayHelloWithDialogButton
  • Then: onTheAppPage.iShouldSeeTheHelloDialog
  • Then: iTearDownMyApp
    The problem is that after this there are only 2 of the 4 implemented (in pages/App.js)
    because of this, the test does not work according to the walkthrough
    Please add those two steps so that the test works
    thanks
@KvM2
Copy link
Contributor

KvM2 commented Oct 28, 2022

Hello , thanks for your contribution! We really appreciate it and will look into this .

@DavidMitreski5 DavidMitreski5 added type/content-gaps Something essential is missing in the documentation. ua-review Under review by the UA team. labels Oct 28, 2022
@KlattG KlattG assigned KlattG and unassigned OlMue Oct 31, 2022
@KlattG
Copy link
Contributor

KlattG commented Nov 10, 2022

Hello @thunermay , the 2 methods you're missing in pages/App.js are provided by OPA and don't have to be implemented there. If your test is failing, the reason should be somewhere else. Therefore I'm closing this issue.

@KlattG KlattG closed this as completed Nov 10, 2022
@OlMue OlMue added the contribution Valuable Contribution label Nov 22, 2023
Copy link

sap-doc-bot bot commented Nov 22, 2023

Thank you for your valuable feedback contribution, @thunermay! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@thunermay
Copy link
Author

@qmacro qmacro added the mission-award SAP Community mission award label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution mission-award SAP Community mission award type/content-gaps Something essential is missing in the documentation. ua-review Under review by the UA team.
Projects
None yet
Development

No branches or pull requests

6 participants