Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML in <code> tags not escaped properly #17

Closed
mbtools opened this issue Nov 18, 2022 · 5 comments
Closed

HTML in <code> tags not escaped properly #17

mbtools opened this issue Nov 18, 2022 · 5 comments
Assignees
Labels
contribution Valuable Contribution mission-award SAP Community mission award type/clarity Something was unclear in the documentation. type/spelling-grammar The spelling or grammar is wrong. ua-review Under review by the UA team.

Comments

@mbtools
Copy link

mbtools commented Nov 18, 2022

The following page contains &nbsp; in the sentence Trailing spaces in text lines are escaped with in the respective BSP pages..

https://github.com/SAP-docs/sapui5/blob/main/docs/05_Developing_Apps/technical-remarks-5a814d9.md

The markdown is correct. However, it's not rendered right:

https://sapui5.hana.ondemand.com/#/topic/5a814d9945d148b0a1ad941791c3c723

The following is not correct:

<code>&nbsp;</code>

The content of the <code> tags must be escaped at render. It should be:

<code>&amp;nbsp;</code>

Please fix the markdown renderer.

@DavidMitreski5
Copy link

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

@DavidMitreski5 DavidMitreski5 added type/clarity Something was unclear in the documentation. type/spelling-grammar The spelling or grammar is wrong. ua-review Under review by the UA team. labels Nov 18, 2022
@OlMue
Copy link
Contributor

OlMue commented Nov 25, 2022

Hi @mbtools
Thanks for spotting this! For some background: The source both for https://sapui5.hana.ondemand.com/#/topic/5a814d9945d148b0a1ad941791c3c723 and for technical-remarks-5a814d9.md is a DITA XML file from our content management system. There's no MD renderer involved here.

But something is obviously going wrong between the DITA XML file and the HTML at https://sapui5.hana.ondemand.com/#/topic/5a814d9945d148b0a1ad941791c3c723. We're going to check that.

Thanks!

@OlMue OlMue closed this as completed Nov 25, 2022
@OlMue OlMue reopened this Nov 25, 2022
@OlMue
Copy link
Contributor

OlMue commented Dec 2, 2022

Thanks again @mbtools! This will be fixed as of 1.110.

@OlMue OlMue closed this as completed Dec 2, 2022
@OlMue OlMue added the contribution Valuable Contribution label Nov 22, 2023
Copy link

sap-doc-bot bot commented Nov 22, 2023

Thank you for your valuable feedback contribution, @mbtools! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@mbtools
Copy link
Author

mbtools commented Nov 22, 2023

@qmacro qmacro added the mission-award SAP Community mission award label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution mission-award SAP Community mission award type/clarity Something was unclear in the documentation. type/spelling-grammar The spelling or grammar is wrong. ua-review Under review by the UA team.
Projects
None yet
Development

No branches or pull requests

4 participants