Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable name mismatch causing undefined variable warnings with SLO and WP_DEBUG #130

Open
kshaner opened this issue Mar 14, 2022 · 0 comments · May be fixed by #131
Open

Variable name mismatch causing undefined variable warnings with SLO and WP_DEBUG #130

kshaner opened this issue Mar 14, 2022 · 0 comments · May be fixed by #131

Comments

@kshaner
Copy link

kshaner commented Mar 14, 2022

The variables $samlNameIdNameQualifier and $samlNameIdSPNameQualifier are defined at the top of the SLO login and never used within the saml_slo function.

Values ARE assigned to $nameIdNameQualifier and $nameIdSPNameQualifier but not previously defined.

https://github.com/onelogin/wordpress-saml/blob/e0e1e68dea4ba100f380efcd7c2331d379376867/onelogin-saml-sso/php/functions.php#L178-L205

I suspect these variables are intended to be the same. With WP_DEBUG on this breaks the SLO process with undefined variable warnings sent before headers are sent to the browser.
kshaner added a commit to kshaner/wordpress-saml that referenced this issue Mar 14, 2022
@kshaner
Fix variable name mismatch
dbdd8fd 
Fixes SAML-Toolkits#130 - variable name mismatch causing php warnings sent before http headers
This was referenced Mar 14, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kshaner