Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program Name "American Express Membership Rewards" Too Long #16

Open
SAMFYB opened this issue Jan 1, 2025 · 2 comments
Open

Program Name "American Express Membership Rewards" Too Long #16

SAMFYB opened this issue Jan 1, 2025 · 2 comments
Labels
bug Something isn't working enhancement New feature or request in progress priority

Comments

@SAMFYB
Copy link
Owner

SAMFYB commented Jan 1, 2025

Program display name "American Express Membership Rewards" is too long comparing to other programs and makes the table column for program names unnecessarily wide. This prevents adding more features to table rows, such as buttons/links to refresh page and history page.

@SAMFYB SAMFYB added bug Something isn't working enhancement New feature or request priority labels Jan 1, 2025
@SAMFYB
Copy link
Owner Author

SAMFYB commented Jan 1, 2025

Attempted to fix this in 409ccba

But this didn't work. We found that because display name is stored in the program data object in storage and then retrieved to show on dashboard table, simply changing it in the code doesn't automatically update. The display name shouldn't be stored. It should be hardcoded so that it's easy to change.

@SAMFYB
Copy link
Owner Author

SAMFYB commented Jan 1, 2025

Opened issue #18 to track the work to remove display name from storage and hardcode in source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request in progress priority
Projects
None yet
Development

No branches or pull requests

1 participant