Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Node.js (KOA) SSR implementation #5

Open
3 tasks
zachsa opened this issue Jun 21, 2022 · 0 comments
Open
3 tasks

[Web] Node.js (KOA) SSR implementation #5

zachsa opened this issue Jun 21, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@zachsa
Copy link
Collaborator

zachsa commented Jun 21, 2022

The Koa.js web app server-side-renders the React client correctly, but there are some issues that could be ironed out:

  • After the initial import the React client is NOT re-imported on the server side. This means that global-scope code on the React side (i.e. configuration) is run only once. The React client should be imported every time the react app is served (I think - TBC)
  • Bundling is currently configured to look at changes only the to entry point of the SSR app. But splitting the entry point across files still needs to result in the Node.js process restarting on file changes.
  • Currently the React app is rendered to a string and that string is then passed to the client. But instead should be rendered to a stream and passed to the client
@zachsa zachsa added the enhancement New feature or request label Jun 21, 2022
@zachsa zachsa self-assigned this Jun 21, 2022
@zachsa zachsa changed the title Node.js (KOA) SSR implementation [Web] Node.js (KOA) SSR implementation Jul 12, 2022
zachsa added a commit that referenced this issue Jul 12, 2022
…rs on rehydration in the browser. and improved translation component code generally to be DRY (all possible locales are indicated in the graphql type system only now)
zachsa added a commit that referenced this issue Jul 12, 2022
…pport for ssr WRT to a 'watched' workflow. the ssr, and transpiled js now lives outside the server source code (#4 #5)
zachsa added a commit that referenced this issue Jul 12, 2022
zachsa added a commit that referenced this issue Aug 23, 2022
…tional error handling when serving / streaming static assets (#5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant