password-hash: fix needless_as_bytes Clippy lint (#1715)

Author: newpavlov

password-hash/src/params.rs

@@ -173,7 +173,7 @@ impl FromStr for ParamsString {
     type Err = Error;
 
     fn from_str(s: &str) -> Result<Self> {
-        if s.as_bytes().len() > MAX_LENGTH {
+        if s.len() > MAX_LENGTH {
             return Err(Error::ParamsMaxExceeded);
         }
 
@@ -201,11 +201,11 @@ impl FromStr for ParamsString {
         }
 
         let mut bytes = [0u8; MAX_LENGTH];
-        bytes[..s.as_bytes().len()].copy_from_slice(s.as_bytes());
+        bytes[..s.len()].copy_from_slice(s.as_bytes());
 
         Ok(Self(Buffer {
             bytes,
-            length: s.as_bytes().len() as u8,
+            length: s.len() as u8,
         }))
     }
 }

password-hash/src/salt.rs

@@ -103,7 +103,7 @@ impl<'a> Salt<'a> {
     /// Create a [`Salt`] from the given B64-encoded input string, validating
     /// [`Salt::MIN_LENGTH`] and [`Salt::MAX_LENGTH`] restrictions.
     pub fn from_b64(input: &'a str) -> Result<Self> {
-        let length = input.as_bytes().len();
+        let length = input.len();
 
         if length < Self::MIN_LENGTH {
             return Err(Error::SaltInvalid(InvalidValue::TooShort));
@@ -215,7 +215,7 @@ impl SaltString {
         // Assert `s` parses successfully as a `Salt`
         Salt::from_b64(s)?;
 
-        let len = s.as_bytes().len();
+        let len = s.len();
 
         let mut bytes = [0u8; Salt::MAX_LENGTH];
         bytes[..len].copy_from_slice(s.as_bytes());

password-hash/src/value.rs

@@ -50,7 +50,7 @@ impl<'a> Value<'a> {
     /// Parse a [`Value`] from the provided `str`, validating it according to
     /// the PHC string format's rules.
     pub fn new(input: &'a str) -> Result<Self> {
-        if input.as_bytes().len() > Self::MAX_LENGTH {
+        if input.len() > Self::MAX_LENGTH {
             return Err(Error::ParamValueInvalid(InvalidValue::TooLong));
         }