Skip to content

2018 edition #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tarcieri opened this issue Aug 12, 2019 · 3 comments
Closed

2018 edition #24

tarcieri opened this issue Aug 12, 2019 · 3 comments

Comments

@tarcieri
Copy link
Member

The minimum Rust version for this repo is presently 1.27.0.

I'd be interested in bumping that up to 1.31.0 and doing a 2018 edition upgrade on all crates.
tarcieri added a commit that referenced this issue Aug 12, 2019
@tarcieri
.travis.yml: Allow warnings on 1.27.0
3c45c82 
There are several `generic-array`-related warnings on 1.27.0:

https://travis-ci.org/RustCrypto/stream-ciphers/jobs/571083202

We should probably phase 1.27.0 out anyway (#24), so ignore them.
@newpavlov
Copy link
Member

We will need to start with trait crates first. Since it will involve bumping minor version we should update generic-array to v0.13 and use this chance to introduce other API changes if needed. I guess I will create a dedicated issue in traits repo.

Also I think we better to jump straight to 1.32. It has some import improvements over 1.31 and this way we will be in sync with getrandom/rand.

@newpavlov
Copy link
Member

See RustCrypto/traits#43

@tarcieri
Copy link
Member Author

tarcieri commented Jun 6, 2020

All crates have been updated to the 2018 edition

@tarcieri tarcieri closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @newpavlov