Skip to content

Commit 6d0d83b

Browse files
committed
.travis.yml: Add RUSTFLAGS="-D warnings" to env
Have CI fail on warnings. There's one warning across the workspace in the `salsa20-crate`. I opened an issue about it here: #23 I've gone ahead and thrown an `allow` attribute on the relevant code so CI passes, which should at least prevent additional warnings from going uncaught on CI.
1 parent ab4b40e commit 6d0d83b

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.travis.yml

+3
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ script:
1010
- cargo test --all --all-features --release
1111
- ./test_aesni.sh
1212

13+
env:
14+
- RUSTFLAGS="-D warnings"
15+
1316
matrix:
1417
allow_failures:
1518
- name: rustfmt

salsa20-core/src/salsa_family_state.rs

+7-2
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,13 @@ pub trait SalsaFamilyCipher {
9393

9494
self.next_block();
9595
} else {
96-
word_idx = 0;
97-
self.next_block();
96+
// TODO(tarcieri): is this else clause unnecessary or is there a bug?
97+
// See: <https://github.com/RustCrypto/stream-ciphers/issues/23>
98+
#[allow(unused_assignments)]
99+
{
100+
word_idx = 0;
101+
self.next_block();
102+
}
98103
}
99104

100105
let nblocks = (datalen - i) / 64;

0 commit comments

Comments
 (0)