-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to configure features passed to minimal-versions
#15
Comments
In that particular case you could use a temporary workaround of adding min-versions-correct |
Here's another example of where it would be handy: RustCrypto/sponges#13 Well, either that, or being able to pin the nightly version. |
Yeah, passing compiler version could be useful with default being Nightly (or version in which |
exclude-features
to minimal-versions
minimal-versions
Another problem related to features passed to This PR needs the ability to specify mandatory features as well as excluded features. Namely we need to pass the It'd be good to get the root problem here, the way curve25519-dalek does backend selection, fixed upstream: |
The
minimal-versions
shared workflow presently doesn't provide a way to pass the--exclude-features
parameter tocargo hack
.This is problematic when using a 3rd party dependency which isn't
minimal-versions
-clean itself. In particular I'm experiencing this withed25519-dalek
:https://github.com/RustCrypto/formats/runs/5739309796?check_suite_focus=true
It would be nice to opt out of
minimal-versions
in these cases by excluding the features from the workflow. While a "proper" fix is making the upstream dependencyminimal-versions
clean, it would be nice in the interim to still have the check work without having to list out the relevant dependencies indev-dependencies
.The text was updated successfully, but these errors were encountered: