Merge pull request #37 from RustCrypto/github-actions/workspace-config-and-clippy-cleanups

.github: run rustfmt + clippy in CI; clippy fixups

Author: tarcieri

.github/workflows/workspace.yml

@@ -0,0 +1,41 @@
+name: Workspace
+
+on:
+  pull_request:
+    paths-ignore:
+      - README.md
+  push:
+    branches: master
+    paths-ignore:
+      - README.md
+
+jobs:
+  clippy:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: 1.41.0 # MSRV
+          components: clippy
+      - run: cargo clippy --all -- -D warnings
+
+  rustfmt:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v1
+
+      - name: Install stable toolchain
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          components: rustfmt
+
+      - name: Run cargo fmt
+        uses: actions-rs/cargo@v1
+        with:
+          command: fmt
+          args: --all -- --check

daa/src/lib.rs

@@ -20,6 +20,7 @@
 #![doc(html_logo_url = "https://raw.githubusercontent.com/RustCrypto/meta/master/logo_small.png")]
 #![forbid(unsafe_code)]
 #![warn(missing_docs, rust_2018_idioms)]
+#![allow(clippy::needless_range_loop)]
 
 pub use crypto_mac::{self, Mac, NewMac};
 
@@ -88,7 +89,7 @@ impl Mac for Daa {
             }
         }
 
-        if data.len() != 0 {
+        if !data.is_empty() {
             self.cipher.encrypt_block(&mut self.buffer);
             for (a, b) in self.buffer.iter_mut().zip(data) {
                 *a ^= *b;

pmac/src/lib.rs

@@ -103,7 +103,7 @@ where
             l_cache[i] = l_cache[i - 1].clone().dbl();
         }
 
-        let l_inv = l0.clone().inv_dbl();
+        let l_inv = l0.inv_dbl();
 
         Self {
             cipher,
@@ -222,7 +222,7 @@ where
 
         self.pos = n;
 
-        if data.len() != 0 {
+        if !data.is_empty() {
             self.process_buffer();
             self.as_mut_bytes()[..data.len()].clone_from_slice(data);
             self.pos = data.len();