Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip duration breaks span len #688

Open
dvdsk opened this issue Jan 23, 2025 · 3 comments
Open

skip duration breaks span len #688

dvdsk opened this issue Jan 23, 2025 · 3 comments
Labels

Comments

@dvdsk
Copy link
Collaborator

dvdsk commented Jan 23, 2025

Skip duration does not take span len into account. It might return samples for a different sample rate and channel count while its parent/wrapper still thinks its in the same span.

Solution:
It should probably pad the current frame with silence if the sample rate and/or channel count do not match after skip.

@dvdsk dvdsk added the bug label Jan 23, 2025
@dvdsk
Copy link
Collaborator Author

dvdsk commented Jan 23, 2025

alternative is to make the queue handle this... might be easier to have all the complexity in one spot.

@dvdsk
Copy link
Collaborator Author

dvdsk commented Jan 23, 2025

closing, handling in queue, behavior is fine by rodio's Source trait

@dvdsk dvdsk closed this as completed Jan 23, 2025
@dvdsk
Copy link
Collaborator Author

dvdsk commented Jan 23, 2025

actually still broken, sample rate might have changed while skipping. Consumer will assume its still the same. No way to let Consumer know...

Need to inject silence OR figure out a way to communicate span change to consumer....

@dvdsk dvdsk reopened this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant