Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method to get which stream was opened #665

Open
dvdsk opened this issue Dec 22, 2024 · 1 comment
Open

method to get which stream was opened #665

dvdsk opened this issue Dec 22, 2024 · 1 comment
Labels
enhancement low_prio Low priority, if you disagree please leave a comment why this is importand for you.

Comments

@dvdsk
Copy link
Collaborator

dvdsk commented Dec 22, 2024

For context see: #662 (comment)

maybe a method on OutputStream would work?

@dvdsk dvdsk added enhancement low_prio Low priority, if you disagree please leave a comment why this is importand for you. labels Dec 22, 2024
@PetrGlad
Copy link
Collaborator

There are 3 options:

  1. Return as another value when opening the stream ((info, stream-handle)). This would force users to ignore info part, and it again looks like the older version of the API...
  2. Just write this info to logs (through tracing).
  3. Keep the information in the stream handle, and let users to read it.

Yes, the latter seems to give users most choices, and does not interfere if they do not care.
I think we'll need to show not only actual device name, but also the actual stream format. So there is possibility for sources to adjust if they can (#646).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement low_prio Low priority, if you disagree please leave a comment why this is importand for you.
Projects
None yet
Development

No branches or pull requests

2 participants