Remove the need to keep the stream around

[dvdsk]

Its a common footgun in using rodio. It should be possible to store the stream in the sink.

Remaining questions, does the stream need to be accessible when a sink is used? If so how? Does sink get a method to get the stream?

Implementation wise it seems like storing the stream in an Arc will work.

[PetrGlad]

Can Sink's output be not a stream but another source? Should they give some shared reference to the output stream in that case?

I would keep sink as simple as possible unless there is a compelling reason to add anything to it. It is a lot harder to remove things from API than to add them.

[PetrGlad]

I am trying to prototype now to see how best to do this.

[dvdsk]

Can Sink's output be not a stream but another source?

Thats actually quite a nice idea. I wonder if there is any reason thats not the case right now... It seems quite elegant!

[dvdsk]

How would it help out for this issue though? The stream still needs to be kept somewhere.

And Sink is not really a footgun atm I rather not change it, Rodio has a ton of users depending on Sink in its current form.