Skip to content

Commit 8035b1a

Browse files
pskrgagkuba-moo
authored andcommitted
asix: fix uninit-value in asix_mdio_read()
asix_read_cmd() may read less than sizeof(smsr) bytes and in this case smsr will be uninitialized. Fail log: BUG: KMSAN: uninit-value in asix_check_host_enable drivers/net/usb/asix_common.c:82 [inline] BUG: KMSAN: uninit-value in asix_check_host_enable drivers/net/usb/asix_common.c:82 [inline] drivers/net/usb/asix_common.c:497 BUG: KMSAN: uninit-value in asix_mdio_read+0x3c1/0xb00 drivers/net/usb/asix_common.c:497 drivers/net/usb/asix_common.c:497 asix_check_host_enable drivers/net/usb/asix_common.c:82 [inline] asix_check_host_enable drivers/net/usb/asix_common.c:82 [inline] drivers/net/usb/asix_common.c:497 asix_mdio_read+0x3c1/0xb00 drivers/net/usb/asix_common.c:497 drivers/net/usb/asix_common.c:497 Fixes: d9fe64e ("net: asix: Add in_pm parameter") Reported-and-tested-by: [email protected] Reviewed-by: Andrew Lunn <[email protected]> Signed-off-by: Pavel Skripkin <[email protected]> Link: https://lore.kernel.org/r/8966e3b514edf39857dd93603fc79ec02e000a75.1640117288.git.paskripkin@gmail.com Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 9b8bdd1 commit 8035b1a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/usb/asix_common.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ static int asix_check_host_enable(struct usbnet *dev, int in_pm)
7777
0, 0, 1, &smsr, in_pm);
7878
if (ret == -ENODEV)
7979
break;
80-
else if (ret < 0)
80+
else if (ret < sizeof(smsr))
8181
continue;
8282
else if (smsr & AX_HOST_EN)
8383
break;

0 commit comments

Comments
 (0)