Skip to content

Upgrade bundled version of SDL to 2.0.9 #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rasky opened this issue Nov 12, 2018 · 4 comments · Fixed by #817
Closed

Upgrade bundled version of SDL to 2.0.9 #808

rasky opened this issue Nov 12, 2018 · 4 comments · Fixed by #817
Labels
build-process Everything related to build.rs, or the build process in general

Comments

@rasky
Copy link
Contributor

rasky commented Nov 12, 2018

Please upgrade the bundled version of SDL to 2.0.9, which includes a fix for MacOS Mojave where canvas is not presented until the window is moved/resized once.

@mattiascibien
Copy link

I second this. By providing 2.0.9 (or at least 2.0.8) it will be possibile to have Vulkan with bundled.

@rombankzero
Copy link
Contributor

The bundled SDL version was reverted from 2.0.8 to 2.0.5 in 0472c00, though I have no idea why. It breaks other things too (see #816).

@mattiascibien
Copy link

mattiascibien commented Dec 3, 2018

@rombankzero I think it was due to a bug in 2.0.6 (and upper I think) #781 (comment). However I think it should have been fixed in 2.0.9 https://hg.libsdl.org/SDL/rev/c0b17b32b95e and the changes for 2.0.9 include that commit https://hg.libsdl.org/SDL/file/8feb5da6f2fb/CMakeLists.txt

@rombankzero
Copy link
Contributor

@mattiascibien Ah, I figured there had to be a reason!

Bumping those version numbers in build.rs to 2.0.9 would be nice. I guess in principle the in-tree SDL headers and bindings should be updated too, though I'm not sure what the usual procedure is there. I'm having no luck with bindgen on Windows; it's just spewing massive, inscrutable error messages at me...

@Cobrand Cobrand added the build-process Everything related to build.rs, or the build process in general label Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-process Everything related to build.rs, or the build process in general
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants