Skip to content

Unify AST::ExternalFunctionitem with AST::Function #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
P-E-P opened this issue Jan 29, 2024 · 2 comments
Closed

Unify AST::ExternalFunctionitem with AST::Function #2820

P-E-P opened this issue Jan 29, 2024 · 2 comments
Assignees
@0xn4utilus
Labels
good-first-pr
Milestone
GCC 14.1 release

Comments

@P-E-P
Copy link
Member

P-E-P commented Jan 29, 2024

The interface for both types is almost the same as well as the attributes. Since #2755 function body can now be optional. This means an ExternalFunctionItem could technically be replaced with a function.

One grey area remains:
External function arguments cannot be pattern (unless it is a named variadic argument).
@P-E-P P-E-P added this to the GCC 14.1 release milestone Jan 29, 2024
@0xn4utilus
Copy link
Contributor

Hello, Is anyone currently working on this issue? I want to work on this issue

@CohenArthur
Copy link
Member

Closed in #2849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xn4utilus 0xn4utilus

Labels
good-first-pr
Projects
Project Pineapple
Status: Done
Milestone
GCC 14.1 release
Development

No branches or pull requests
3 participants
@P-E-P @CohenArthur @0xn4utilus