Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Transformer catalogue #95

Closed
2 tasks done
benoit9126 opened this issue Jul 10, 2023 · 0 comments · Fixed by #118 or #124
Closed
2 tasks done

ENH: Transformer catalogue #95

benoit9126 opened this issue Jul 10, 2023 · 0 comments · Fixed by #118 or #124
Assignees
@benoit9126
Labels
enhancement New feature or request

Comments

@benoit9126
Copy link
Member

benoit9126 commented Jul 10, 2023 •
edited
Loading

I have done a small catalogue of three-phase transformers for another project. I can add this catalogue to the data of the repository.

  • Add a from_catalogue(cls, manufacturer: str, **kwargs) class method to the TransformerParameters class.
  • Add a print_catalogue(cls, manufacturer: str |None=None, **kwargs) to print the catalogue of transformers. Optional arguments allow the user to print a subpart of the catalogue only. TransformerParameters.print_catalogue(manufacturer="SE", product_type="Minera")
@benoit9126 benoit9126 added the enhancement New feature or request label Jul 10, 2023
@benoit9126 benoit9126 self-assigned this Jul 10, 2023
benoit9126 added a commit that referenced this issue Aug 11, 2023
@benoit9126
Close #95
bf8343c
@benoit9126 benoit9126 linked a pull request Aug 11, 2023 that will close this issue
Add a catalogue of transformers #118
Merged
@benoit9126 benoit9126 mentioned this issue Aug 29, 2023
Merged
@benoit9126 benoit9126 linked a pull request Aug 29, 2023 that will close this issue
Version 0.5.0 #124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoit9126 benoit9126

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@benoit9126