Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Improve some of LineParameters alternative constructors #252

Closed
4 tasks
alihamdan opened this issue Aug 5, 2024 · 0 comments · Fixed by #257
Closed
4 tasks

ENH: Improve some of LineParameters alternative constructors #252

alihamdan opened this issue Aug 5, 2024 · 0 comments · Fixed by #257
Assignees
@alihamdan
Labels
enhancement New feature or request

Comments

@alihamdan
Copy link
Member

alihamdan commented Aug 5, 2024 •
edited
Loading

  • The method from_name_lv, deprecated since version 0.6, should be removed. It can be easily replaced by from_geometry
  • The method from_name_mv is to be renamed to from_coiffier or from_coiffier_model.
    • it can also benefit from automatic ampacity calculation using Coiffier's method.
    • it can also be updated to accept a number of phases argument similar to from_catalogue

Related #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alihamdan alihamdan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add from_coiffier_model method to line parameters RoseauTechnologies/Roseau_Load_Flow
1 participant
@alihamdan