refactor: code

refs: #49

Author: pirs1337

src/Generators/ModelGenerator.php

@@ -25,7 +25,7 @@ public function generate(): void
             );
         }
 
-        if ($this->isStubExists('model') && (collect($this->relations)->every(fn ($relation) => empty($relation)) || $this->isStubExists('relation', 'model'))) {
+        if ($this->isStubExists('model') && (!$this->hasRelations() || $this->isStubExists('relation', 'model'))) {
             $this->prepareRelatedModels();
             $modelContent = $this->getNewModelContent();
 
@@ -35,6 +35,11 @@ public function generate(): void
         }
     }
 
+    protected function hasRelations(): bool
+    {
+        return !collect($this->relations)->every(fn ($relation) => empty($relation));
+    }
+
     protected function getNewModelContent(): string
     {
         return $this->getStub('model', [

tests/FactoryGeneratorTest.php

@@ -50,7 +50,6 @@ className: ClassAlreadyExistsException::class,
 
     public function testProcessUnknownFieldType()
     {
-        $this->mockConfigurations();
         $this->mockFilesystem();
 
         $this->assertExceptionThrew(
@@ -75,7 +74,6 @@ className: ViewException::class,
 
     public function testCreateSuccess()
     {
-        $this->mockConfigurations();
         $this->mockFilesystem();
 
         app(FactoryGenerator::class)

tests/MigrationGeneratorTest.php

@@ -5,16 +5,11 @@
 use Illuminate\Support\Carbon;
 use RonasIT\Support\Exceptions\UnknownFieldTypeException;
 use RonasIT\Support\Generators\MigrationGenerator;
-use RonasIT\Support\Tests\Support\Migration\MigrationMockTrait;
 
 class MigrationGeneratorTest extends TestCase
 {
-    use MigrationMockTrait;
-
     public function testSetUnknownFieldType()
     {
-        $this->setupConfigurations();
-
         $this->assertExceptionThrew(
             className: UnknownFieldTypeException::class,
             message: 'Unknown field type unknown-type in MigrationGenerator.',
@@ -39,9 +34,6 @@ public function testCreateMigration()
     {
         Carbon::setTestNow('2022-02-02');
 
-        $this->mockFilesystem();
-        $this->setupConfigurations();
-
         app(MigrationGenerator::class)
             ->setModel('Post')
             ->setRelations([
@@ -67,9 +59,6 @@ public function testCreateMigrationMYSQL()
 
         Carbon::setTestNow('2022-02-02');
 
-        $this->mockFilesystem();
-        $this->setupConfigurations();
-
         app(MigrationGenerator::class)
             ->setModel('Post')
             ->setRelations([

tests/SeederGeneratorTest.php

@@ -4,16 +4,11 @@
 
 use RonasIT\Support\Events\WarningEvent;
 use RonasIT\Support\Generators\SeederGenerator;
-use RonasIT\Support\Tests\Support\SeederGeneratorMockTrait;
 
 class SeederGeneratorTest extends TestCase
 {
-    use SeederGeneratorMockTrait;
-
     public function testCreateSeeder()
     {
-        $this->mockFilesystem();
-
         app(SeederGenerator::class)
             ->setRelations([
                 'hasOne' => [],
@@ -30,8 +25,6 @@ public function testCreateSeeder()
 
     public function testCreateSeederEmptyDatabaseSeederStubNotExist()
     {
-        $this->mockFilesystem();
-
         config(['entity-generator.stubs.database_empty_seeder' => 'entity-generator::database_seed_empty']);
 
         app(SeederGenerator::class)
@@ -55,8 +48,6 @@ className: WarningEvent::class,
 
     public function testCreateSeederEntityDatabaseSeederStubNotExist()
     {
-        $this->mockFilesystem();
-
         config(['entity-generator.stubs.seeder' => 'incorrect_stub']);
 
         app(SeederGenerator::class)

tests/Support/Factory/FactoryMockTrait.php

@@ -2,8 +2,8 @@
 
 namespace RonasIT\Support\Tests\Support\Factory;
 
-use org\bovigo\vfs\vfsStream;
 use RonasIT\Support\Generators\FactoryGenerator;
+use RonasIT\Support\Tests\Support\FileSystemMock;
 use RonasIT\Support\Tests\Support\GeneratorMockTrait;
 
 trait FactoryMockTrait
@@ -15,30 +15,15 @@ public function mockFactoryGenerator(array ...$functionCalls): void
         $this->mockClass(FactoryGenerator::class, $functionCalls);
     }
 
-    public function mockConfigurations(): void
-    {
-        config([
-            'entity-generator.paths' => [
-                'models' => 'app/Models',
-                'factories' => 'database/factories',
-            ],
-        ]);
-    }
-
     public function mockFilesystem(): void
     {
-        $structure = [
-            'app' => [
-                'Models' => [
-                    'Post.php' => $this->mockPhpFileContent(),
-                    'User.php' => $this->mockPhpFileContent(),
-                ],
-            ],
-            'database' => [
-                'factories' => [],
-            ],
+        $fileSystemMock = new FileSystemMock;
+
+        $fileSystemMock->models = [
+            'Post.php' => $this->mockPhpFileContent(),
+            'User.php' => $this->mockPhpFileContent(),
         ];
 
-        vfsStream::create($structure);
+        $fileSystemMock->setStructure();
     }
 }

tests/Support/Migration/MigrationMockTrait.php

@@ -2,7 +2,7 @@
 
 namespace RonasIT\Support\Tests\Support\Model;
 
-use org\bovigo\vfs\vfsStream;
+use RonasIT\Support\Tests\Support\FileSystemMock;
 use RonasIT\Support\Tests\Support\GeneratorMockTrait;
 
 trait ModelMockTrait
@@ -11,15 +11,13 @@ trait ModelMockTrait
 
     public function mockFilesystem(): void
     {
-        $structure = [
-            'app' => [
-                'Models' => [
-                    'Comment.php' => file_get_contents(getcwd() . '/tests/Support/Models/WelcomeBonus.php'),
-                    'User.php' => file_get_contents(getcwd() . '/tests/Support/Models/WelcomeBonus.php'),
-                ],
-            ],
+        $fileSystemMock = new FileSystemMock;
+
+        $fileSystemMock->models = [
+            'Comment.php' => file_get_contents(getcwd() . '/tests/Support/Models/WelcomeBonus.php'),
+            'User.php' => file_get_contents(getcwd() . '/tests/Support/Models/WelcomeBonus.php'),
         ];
 
-        vfsStream::create($structure);
+        $fileSystemMock->setStructure();
     }
 }