ADSR Class [for uiCustomComponent]: NEED 'OnMouseDown() Snap MouseXY to NodeXY': Any Ctrlr Hooks(or trix) for this? #624
-
|
Working on an ADSR Class and needing To break down what's needed in simple terms:
Any thoughts regarding how one might implement 'snap mouse cursor to XY' are much appreciated
|
Beta Was this translation helpful? Give feedback.
Replies: 11 comments 35 replies
-
|
Hi, there's a JUCE class especially for ADSR management. |
Beta Was this translation helpful? Give feedback.
-
|
EDIT: The JUCE ADSR Class won't work, it's audio related... sorry, I have no idea. If we need new JUCE callbacks attached to the customComponent for that particular task, let me know, I'll add them then. |
Beta Was this translation helpful? Give feedback.
-
|
it actually still might have something useable with respect to mousing.. will take a gander. THANK YOU |
Beta Was this translation helpful? Give feedback.
-
|
@damiensellier : Found a solution on the juce boards... off to Ctrlr-code to see if there is anything related. Not sure if I can https://forum.juce.com/t/move-the-mouse-to-a-component-solved/23160/2 Issue:Is it possible to move the mouse (cursor) programatically to a component? Say I have a component e.g. a cursor that moves “by itself” due to automation. When I click on it (or its containing component), I want the mouse to snap to its position so I can continue record the automation from that moment smoothly without any discontinuity. I.e, the opposite behaviour the juce slider exhibits, where the the thumb snaps to the mouse. Solution via C++Thanks Holy_City. It turned out to be easier than I feared to transfer the drag from the parent component to the sliderThumb. Here’s the complete solution to move the mouse to the current position of the slider thumb (or whatever appropriate child component) and smoothly continue the drag from its current position (instead of the usual thumb jump to the mouse position) void MyComponent::mouseDown(const MouseEvent& e) noexcept
{
e.source.setScreenPosition(mySliderThumb->getScreenBounds().getCentre().toFloat());
MouseEvent eThumb = e.withNewMouseDownPosition(mySliderThumb->getBounds().getCentre());
mySliderThumb->sliderThumbDragger.startDraggingComponent(mySliderThumb, eThumb);
}and in void MyComponent::mouseDrag(const MouseEvent& e) noexcept
{
mySliderThumb->sliderThumbDragger.dragComponent(mySliderThumb, e, nullptr);
}
Hmm, well not quite, the mouse cursor isn’t changed to a dragging cursor but stays in its normal arrow mode during the drag, but I gues I can live with that…You can call Component::setMouseCursor (MouseCursor::DraggingHandCursor)in your mouse event callback. |
Beta Was this translation helpful? Give feedback.
-
|
Lua/JuceClasses/LMouseEvent.h doesn't have that hook, but has these... will look more tomorrow /** Creates a copy of this event with a different position.
All other members of the event object are the same, but the x and y are
replaced with these new values.
*/
MouseEvent withNewPosition (Point<float> newPosition) const noexcept;
/** Creates a copy of this event with a different position.
All other members of the event object are the same, but the x and y are
replaced with these new values.
*/
MouseEvent withNewPosition (Point<int> newPosition) const noexcept;also tried sniffing with what: what(event)
what(event.source) |
Beta Was this translation helpful? Give feedback.
-
|
Please take a look at @dnaldoog d990 panel, there's a ADSR graph with nodes you can move with mouse down etc : https://sourceforge.net/projects/jd990-super-editor/
|
Beta Was this translation helpful? Give feedback.
-
|
@damiensellier lol...yessir... that JD990 is what got me started on this 😛 .. I actually have been camping out on it : @dnaldoog .. that 990 is a lovely panel sir!
THANKS for the JUCE info, will poke around & see if I get lucky. If not the 990's drag code code is here looking at me & will probably implement something similar based off of it & just revisit my 'mouse snapping' thing later. I'll update if I find a solution. debugging paint callback
|
Beta Was this translation helpful? Give feedback.
-
Because the code is so convoluted and overly complicated so that when I went to rewrite it, I decided I would be better to just start from scratch, which I am gradually doing when I get around to it. But that code has been pretty well tested. |
Beta Was this translation helpful? Give feedback.
-
|
What is it exactly that you need to know about mouse movement or dragging? It's not clear to me what the problem is. |
Beta Was this translation helpful? Give feedback.
-
|
Same feeling... Don't understand what the problem is. In the OnMouseDown method you need to track the anchors zones. For the moment, yep, 3 methods by envelope but you can easily make only 3 for all envelopes if you prefer. For the colour you use According to the envelope type, it is a matter to adapt the standard paint env code that you can find in different panels. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, I think I finally get the problem. You want to click "somewhere" in the component and make a "node" snap to the point you clicked. Then you first need to "know" where all the nodes are and do a quick math to calculate the distance to the node that is closer to the point you clicked than the rest of the nodes. If you ask me, the best way is to determine the x point of a node (the nodes can't overlap and are in a certain order) and compare that to the x point of the mouse click. Then swap the x,y of the closest node with the ones of the mouse click. But to make matters worse, you first have to define "which" graph (or colored line) you want to snap as well. Should be possible if you can select the graph that you need. Possibly with a graph (color) selector. |
Beta Was this translation helpful? Give feedback.
-
|
@Ted-juh
/** The source device that generated this event. */
MouseInputSource source;
|
Beta Was this translation helpful? Give feedback.
-
|
@damiensellier .. I just added LMouseInputSource, built successfully and the object/method are now exposed to Ctrlr. Ctrlr might be lying & just mimicking what's in the
LMouseInputSource Luabind Add
#ifndef L_MOUSE_INPUT_SOURCE
#define L_MOUSE_INPUT_SOURCE
extern "C"
{
#include "lua.h"
}
class LMouseInputSource
{
public:
static void wrapForLua(lua_State* L);
};
#endif
#include "LMouseInputSource.h"
LMouseInputSource::wrapForLua(L);
void LMouseEvent::wrapForLua (lua_State *L)
{
using namespace luabind;
module(L)
[
class_<MouseEvent>("MouseEvent")
.def("getMouseDownX", &MouseEvent::getMouseDownX)
.def_readonly("source", &MouseEvent::source) <<----
.def_readonly("x", &MouseEvent::x)
.def_readonly("y", &MouseEvent::y)UPDATE 3/25
void LMouseInputSource::wrapForLua(lua_State* L)
{
using namespace luabind;
module(L)
[
class_<MouseInputSource>("MouseInputSource")
.def("setScreenPosition", &MouseInputSource::setScreenPosition)
];
}UPDATE 3/25--
-- Called when a mouse is down on this component
--
ButtonOnClick = function(--[[ CtrlrComponent --]] comp, --[[ MouseEvent --]] event)
what(event.x)
what(event.source)
end |
Beta Was this translation helpful? Give feedback.
-
|
@damiensellier FYI: Its working --
-- Called when a mouse is down on this component
--
ButtonOnClick = function(--[[ CtrlrComponent --]] comp, --[[ MouseEvent --]] event)
what(event.x)
what(event.source)
event.source:setScreenPosition(Point(50,50))
console("move mouse")
end |
Beta Was this translation helpful? Give feedback.
-
|
I was just looking at this but on 5.3.201 - I had got as far as mouseUp = function(--[[ CtrlrComponent --]] comp, --[[ MouseEvent --]] event) local x,y=event.x,event.y local p=Point() p:setX(mouseTarget.x) p:setY(mouseTarget.y) event.source:setScreenPosition(p) end Does this panel work on 5.6.31? UPDATE EDIT |
Beta Was this translation helpful? Give feedback.
-
|
yeah.. its on my end... tail end of a Ctrlr Marathon apparently.. I didn't capture the luabind for the
|
Beta Was this translation helpful? Give feedback.
-
|
Hi UC, sounds good! |
Beta Was this translation helpful? Give feedback.
-
|
I just added them and it compiled well on mac. The new class will be available in CtrlrX v5.6.31 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @damiensellier for posting that panel as an example of an ADSR (type) graph. I have been working on and off on a complete rewrite of the JD-990 panel. The code in that currently released panel was written when I was just starting out with Ctrlr and as such could use a few improvements and streamlining. Anyway, I have separated the latest graph code and added it to a dedicated panel, which should make it easier to decipher for @unityconstruct and others.
|
Beta Was this translation helpful? Give feedback.
-
|
Bump: does this panel work in 5.6.31? |
Beta Was this translation helpful? Give feedback.
-
|
I had like 15 errors in xcode. I tried to remove the constructor with the enum type keeping only the constructor but it failed too. e.source.setScreenPosition(juce::Point(0,0)); // failing
Not sure if setScreenPosition will work in our case. |
Beta Was this translation helpful? Give feedback.
-
|
Ah.. dang. It's quite simple. You can't create a new MouseInputSource so the first constructor is at fault. Now it compiles. But not sure if it works. |
Beta Was this translation helpful? Give feedback.
-
|
Compilation went ok but the 2 demo panels are not working. Time to sleep. Have a nice week! |
Beta Was this translation helpful? Give feedback.
-
|
And if you ask me, it should be: See the Juce Class: |
Beta Was this translation helpful? Give feedback.
-
|
doh!... @damiensellier
.def_readonly("source", &MouseEvent::source)
|
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks, I just updated the missing line and it seems to work. From @dnaldoog test panel I have my mouse pointer jumpingto another position when clicking and it returns in the debugger the following : With UC panel I get the following message in the LUA console, and the pointer is jumping to the screen pos (x50,y50) as desired: So, kudos! it seems to work, it will be available in the next release v5.6.31 Have a nice week ;) |
Beta Was this translation helpful? Give feedback.
-
|
Wow that’s great work @damiensellier - it’s really exciting to see how quickly you can move on these things and get them incorporated. just got to find a use for having a jumping mouse now! Ha ha.😂 |
Beta Was this translation helpful? Give feedback.
-
|
A classic & stylish implementation is to have the MouseDown() event first move the cursor to the close icon before proceeding to honor the Click() |
Beta Was this translation helpful? Give feedback.
-
|
It actually is a very good idea now that I think about it, because sometimes centering the mouse on the small rectangles in, for example, a graph can be a little fiddly, whereas if the mouse does a kind of honing in action, I can see that that would be quite cool! |
Beta Was this translation helpful? Give feedback.
-
|
I fail to understand why this method would differ from withNewPosition (which is a Mouse event). To me it should pass the new coordinates to the mouse. Doesn't matter that much, it works as intended the way it is now. User cases: Or for a linear bar, snap to the value instead of that the point you clicked becomes the new value. Or, with a long combobox or menu, make it jump back to the start. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
So, screen as in screen position means the "monitor" here, I guess. It's not obvious from the description in the mouseInputSource class. Whereas is the Mouse event class it is obvious: I wonder what withNewPosition() does because of its description: "All other members of the event object are the same, but the x and y are replaced with these new values.". If the component is a member of the mouse event.. its coordinates should correspond to the component and not that of the monitor. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, it's all in the name - screen means the screen - ! Was messing about with: .def("getLocalPoint", (Point (Component::*)(const Component *, Point) const) &Component::getLocalPoint)
//.def("getLocalArea", &Component::getLocalArea)
.def("localPointToGlobal", (Point (Component::*)(Point) const) &Component::localPointToGlobal)
but don't seem to be bound? |
Beta Was this translation helpful? Give feedback.
-
|
That's in LComponents.cpp ? Yes, it is indeed. Mind that there are two ways to add the getLocalPoint with Luabind. One with and one with . See The component class in Juce. How are you using it in a panel? |
Beta Was this translation helpful? Give feedback.
-
now that I figured out that luabind, I'm prob dangerous at this point |
Beta Was this translation helpful? Give feedback.
@damiensellier .. I just added LMouseInputSource, built successfully and the object/method are now exposed to Ctrlr. Ctrlr might be lying & just mimicking what's in the
wrapForLuasetup, but about to find out. If it actually works, not sure if you are ok if I pull from CtrlrX, update & do PR. If not, I can just maintain it in my fork. THX for your responses above as they more or less led me to where I needed to be.LMouseInputSource Luabind Add