Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: Idle Time Limit misses unit #33566

Open
LenzGr opened this issue Oct 14, 2024 · 16 comments · May be fixed by #34899
Open

UX: Idle Time Limit misses unit #33566

LenzGr opened this issue Oct 14, 2024 · 16 comments · May be fixed by #34899
Labels
Tasked Added to the internal issue tracking

Comments

@LenzGr
Copy link

LenzGr commented Oct 14, 2024

Description:

In the account preferences, there's an option to enable the "Auto Away" feature and an option to define an "Idle Time Limit". The text box provides no guidance about what unit this time limit is defined in. Based on the number (3600 in my case), a more technical user can probably deduct that the unit is seconds, but it would be helpful to provide some guidance here, at least by informing the user that the limit is defined in seconds, ideally by giving them a way to define the value in a more human-readable way (in hours, minutes, seconds).

Screenshot 2024-09-27 at 09 51 44

Steps to reproduce:

  1. Click your avatar icon
  2. Select "Preferences"
  3. Select "User Presence"
  4. Note the input field for "Idle Time Limit" showing a number without any units associated

Expected behavior:

The Idle Time Limit input field should indicate the unit used, or provide a more human-friendly way of selecting a time period.

Actual behavior:

The input fields does not provide any guidance of what to enter here.

Server Setup Information:

N/A (can't provide this information as a regular user on our platform)

Client Setup Information

  • Desktop App v4.1.1 on macOS
@thepiyush-303
Copy link
Contributor

Hello @LenzGr
Is this what you are looking for?
Screenshot from 2024-10-15 10-42-33

@LenzGr
Copy link
Author

LenzGr commented Oct 15, 2024

Hello @LenzGr Is this what you are looking for?

Thanks, @thepiyush-303 that would already be a step forward for sure! The icing on the cake would being able to use human-readable units here, e.g. using a time picker that allows me to choose hours, minutes and seconds...

@thepiyush-303
Copy link
Contributor

For sure, I'll have it ready by tomorrow!

@ritankarsaha
Copy link

@LenzGr I would like to work on this issue. Could I get this assigned?

@thepiyush-303
Copy link
Contributor

thepiyush-303 commented Oct 16, 2024 •
edited
Loading

hey @ritankarsaha
Currently I am working on it, I am new to the project that's why it's taking time but I have gained a lot of knowledge
The feature will setup by adding input-fields calculating them and registering them with "IdleTimeLimit" paramater
Thanks,

@ritankarsaha
Copy link

hey @ritankarsaha
Currently I am working on it, I am new to the project that's why it's taking time but I have gained a lot of knowledge
The feature will setup by adding input-fields calculating them and registering them with "IdleTimeLimit" paramater
Thanks,

Sure @thepiyush-303 . I didn't realise you were still working on this issue. If u want to collaborate feel free to drop a ping.
Thanks.

@thepiyush-303
Copy link
Contributor

Hey @ritankarsaha , I'd love to collaborate, but my schedule is a bit packed at the moment. I’ll definitely get back to you once things ease up a bit, and we can explore how to work together :)

@ritankarsaha
Copy link

Hey @ritankarsaha , I'd love to collaborate, but my schedule is a bit packed at the moment. I’ll definitely get back to you once things ease up a bit, and we can explore how to work together :)

Sure @thepiyush-303

@thepiyush-303 thepiyush-303 mentioned this issue Oct 22, 2024
Closed
@thepiyush-303
Copy link
Contributor

thepiyush-303 commented Oct 22, 2024 •
edited
Loading

Hey @LenzGr ,
I've made requested changes, here's an image that highlights the updates.
Screenshot from 2024-10-22 21-18-46
I also have generated PR #33708 on this changes

@ritankarsaha
Copy link

Hey @ritankarsaha ,
I've made requested changes, here's an image that highlights the updates.
Screenshot from 2024-10-22 21-18-46
I also have generated PR #33708 on this changes

Ohh nice @thepiyush-303

@ritankarsaha
Copy link

@thepiyush-303 Is this issue completely solved ?

@LenzGr
Copy link
Author

LenzGr commented Oct 28, 2024

Hey @LenzGr , I've made requested changes, here's an image that highlights the updates. Screenshot from 2024-10-22 21-18-46 I also have generated PR #33708 on this changes

Looks good to me, thank you! From an end-user perspective, this is more intuitive.

@reetp
Copy link

reetp commented Nov 11, 2024

Please refer to #33708

This has not been finished and there is commentary on that PR by the team.

@reetp reetp added the Tasked Added to the internal issue tracking label Nov 11, 2024
@casalsgh
Copy link
Contributor

Team, checking the issue with internal teams, from there will try to get a review on proposed PR.

@casalsgh
Copy link
Contributor

Sorry, there is already a PR proposed and got reviews. Changes requested, including a proposal for alternative solution.
will keep an eye

@thepiyush-303
Copy link
Contributor

I have made requested changes per the alternate solution.
#33708

@thepiyush-303 thepiyush-303 linked a pull request Jan 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tasked Added to the internal issue tracking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add Input fields in userPreferences/idleTimeLimit option. thepiyush-303/Rocket.Chat
6 participants
@LenzGr @reetp @casalsgh @ritankarsaha @thepiyush-303 and others