Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : migrate root component to react functional component #6033

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

fix : migrate root component to react functional component #6033

wants to merge 10 commits into from

Conversation

divyanshu-patil
Copy link

@divyanshu-patil divyanshu-patil commented Nov 30, 2024 •
edited
Loading

Proposed changes

Fix : #6031
this pull request migrate the root component from the React class component to the React functional component, ensuring that the code follows best react practices

Issue(s)

#6031

changed files

this going to change the root component in app/index.tsx

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Rohit3523
Copy link
Contributor

Hello, can you remove 'fixed #6031' from the title and start the title with 'fix: ' instead of '[FIX]' to align it with the PR title convention we follow.

Thanks

@divyanshu-patil divyanshu-patil changed the title [FIX] fixed #6031 migrate root component to react functional component fix : migrate root component to react functional component Nov 30, 2024
@divyanshu-patil
Copy link
Author

Hello, can you remove 'fixed #6031' from the title and start the title with 'fix: ' instead of '[FIX]' to align it with the PR title convention we follow.

Thanks

done, thanks for feedback

diegolmello
diegolmello requested changes Dec 2, 2024
View reviewed changes
app/index.tsx Outdated Show resolved Hide resolved
app/index.tsx Outdated Show resolved Hide resolved
app/index.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello Awaiting requested review from diegolmello

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update root component to React functional component.
4 participants
@divyanshu-patil @CLAassistant @Rohit3523 @diegolmello