New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in 0.3.1 causes import bug with module which has only 1 export #41

Open

cuonghuunguyen opened this issue Nov 23, 2021 · 1 comment · May be fixed by #43

Contributor

cuonghuunguyen commented Nov 23, 2021 •

edited

Loading

The fix in 0.3.1 cannot fit every case. It causes an error when packaging my App at: https://github.com/cuonghuunguyen/Rocket-Chat-Livechat-Clean

// constants/scheduled-jobs.ts
export const JobID = {
    CLEAN_ROOMS: 'CLEAN_ROOMS',
};

```ts
// scheduled-jobs/clean-rooms.ts
import {JobID} from '../constants/scheduled-jobs';
JobID.CLEAN_ROOMS
^^^ cannot read property CLEAN_ROOMS of undefined

The logs of the Apps CLI is not good so I had to spend hours debugging it 😓
Packaging and Deploying with my own (private) App Packager works fine

Shailesh351 commented Nov 23, 2021

I can confirm this issue. https://open.rocket.chat/channel/rocketchat-apps?msg=ElRicDQZB8WRRfSxH

debdutdeb linked a pull request

that will close this issue

[FIX] single export TypeError: cannot read properties error #43

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment