-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Backport updated Top Menu Bar #73
Comments
Hey, I am willing to work on this issue, Currently, I going through both repo, and trying to understand the logics and changes that need to be done. Can you assign the issue to me? |
Hey @Aashray446 Once we have discussed the approach, it will make things easier for you to work on, and the community can also help if they understand better what you are trying to do. Thank you! |
OK, thanks for the reply, I am on the way to coming up with something. I will explain my approach soon. Thank you |
I went to the component codes of both menubar, there won't be any conflicts, those menus are completely isolated and there are only three components that required changes. Only the profile picture of the person is a little concerning, I need to figure a way out to consume the profile images. My approach is simple, making a new component that will have the exact same component as in the Rocketchat community, and then replacing the new menubar with the old in Eventadmin |
@Dnouv I have a good idea about how to approach it. It's just I don't know how detailed I need to describe the way of implementing it. Hope I got it right, I am open to your suggestions. |
Sure, go ahead to start backporting it; just take care of this part of code Thank you! |
Ok sure, I will take care of that :-) |
@Dnouv I have sent a pull request, I am open to your suggestions :-) |
@Dnouv sir, I have a small doubt. As you mentioned, the "Click to Chat " button should be hidden when the user is not logged in. The dummy login button is setting the sessionStorage for the dummy user But in the menubar, it's checking the Cookies to check whether the User is logged in or not Is that the reason, this button is not able to appear even after the login? |
Correct, please don't show the As for how to check if a user is logged in or not, there is a cookie PS. Please feel free to address me as only |
@Dnouv thanks for the information. I have included the changes you mentioned and created a PR. Thank you! :-) |
* [NEW] : backport improve navbar #73 * [FIX] : Mapping and rendering error in nav * <FIX> : Navbar links visibility * improve color contrast for better acessibility & prettify Co-authored-by: Dnouv <[email protected]>
@Dnouv You can close this issue 😃 |
* [NEW] : backport improve navbar #73 * [FIX] : Mapping and rendering error in nav * <FIX> : Navbar links visibility * improve color contrast for better acessibility & prettify Co-authored-by: Dnouv <[email protected]>
We need to backport this PR to RC4Conferences RocketChat/RC4Community#193, which updates the UI and logic of the Top Menu Bar.
Thank you!
The text was updated successfully, but these errors were encountered: