Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Explore the possibility of migrating the Google Based RC Auth #51

Open
Dnouv opened this issue Sep 29, 2022 · 3 comments
Open

[MISC] Explore the possibility of migrating the Google Based RC Auth #51

Dnouv opened this issue Sep 29, 2022 · 3 comments

Comments

@Dnouv
Copy link
Member

Dnouv commented Sep 29, 2022

Currently, the Rocket Chat authentication is based on Google OAuth, and the component which handles the authentication does it using API calls inside the custom function files. To make it more compatible with the NextJS, explore the possibility of migrating the Authentication handling with the NextAuth.

Thank you!

@Shivam164
Copy link

@Dnouv Can you specify in the code, where are we doing Google auth?

@Dnouv
Copy link
Member Author

Dnouv commented Dec 20, 2022

@Shivam164, you can explore the project directory; it is well organized to locate many different components quickly. Here is the component file (https://github.com/RocketChat/RC4Conferences/tree/main/app/components/auth/goauth)

The directory can be read as follows:

  1. All the components are located under the components
  2. Now under the components, we have all the components listed, now since you are looking for something related to Authentication, it should be under auth (first four letters of Authentication)
  3. Authentication can be of different services; since we are looking for something related to Google OAuth, it must be under goauth.
  4. If you were looking for contributions to firebase auth, it can be located under the firebase

Thank you!

@VipinDevelops
Copy link

VipinDevelops commented Feb 14, 2023

Hey, @Dnouv I got your point about this issue currently we are using Gapi-cjs in this file using the google auth and getting the access_token, and id_token we want to change that and use something which is provided by NextAuth like this correct me if I am wrong
I want to work on this issue as I have a deep understanding of how google auth is working behind the scene and I am aware of Roket Chat API and how they work
and I think correctly I don't have much better ideas and solutions for this issue ill try to come up with a better idea for this for sure once I get a better idea of how scripts work in this project for a now I am willing to do fix this issue please assign it to me
Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants