Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: added functionality for popups can act as modals on mobile devices #690

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dhairyashiil
Copy link

@dhairyashiil dhairyashiil commented Dec 17, 2024

Brief Title

FEAT: added functionality for popups can act as modals on mobile devices

Acceptance Criteria fulfillment

  • Currently, the popups are strictly positioned. A more flexible positioning system is implemented. On mobile devices, these popups act as modals.

Fixes #629

Video/Screenshots

2024-12-17.14-15-13.mp4

and

2024-12-17.14-16-23.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-690 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Sorry, but why will i want toast message to be displayed on the center of the screen ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT: Make EmbeddedChat more mobile responsive
2 participants