-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to fail-fast on deprecations #159
Comments
I broke drake-external-examples master again because of this via https://reviewable.io/reviews/RobotLocomotion/drake/12680. Drake removed a deprecated text_logging_gflags header, but it remained used by drake-external-examples until it was fully removed and thus broke the build. |
Per f2f: C++ should be easy ( For Python, will be annoying (env vars with test runners, updating each testing mode, or parsing stdout), but doable. |
Note that we can't just turn on |
I think when I work on RobotLocomotion/drake#19167 soon, I should circle back and toggle it here as well. |
Deprecations generally slip through, and cause breakage when their removed.
The text was updated successfully, but these errors were encountered: