Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to fail-fast on deprecations #159

Open
EricCousineau-TRI opened this issue Jan 30, 2020 · 4 comments
Open

Need to fail-fast on deprecations #159

EricCousineau-TRI opened this issue Jan 30, 2020 · 4 comments
Assignees

Comments

@EricCousineau-TRI
Copy link
Collaborator

Deprecations generally slip through, and cause breakage when their removed.

@jwnimmer-tri
Copy link
Contributor

I broke drake-external-examples master again because of this via https://reviewable.io/reviews/RobotLocomotion/drake/12680. Drake removed a deprecated text_logging_gflags header, but it remained used by drake-external-examples until it was fully removed and thus broke the build.

@EricCousineau-TRI
Copy link
Collaborator Author

Per f2f: C++ should be easy (-Wdeprecations or what not), if we're not already doing that.

For Python, will be annoying (env vars with test runners, updating each testing mode, or parsing stdout), but doable.

@jwnimmer-tri
Copy link
Contributor

Note that we can't just turn on -Werror -- these repositories are intended for users to copy into their own project, and we don't want them using -Werror. So the trick is to find a way for us to get CI reports about these, but for that not to propagate that into users' replicas of this.

@jwnimmer-tri
Copy link
Contributor

I think when I work on RobotLocomotion/drake#19167 soon, I should circle back and toggle it here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants