Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Manager Usage #13

Open
1 of 2 tasks
ahasselbring opened this issue Apr 11, 2023 · 3 comments
Open
1 of 2 tasks

Package Manager Usage #13

ahasselbring opened this issue Apr 11, 2023 · 3 comments

Comments

@ahasselbring
Copy link
Member

ahasselbring commented Apr 11, 2023

  • Do we want to have Cargo.lock and package-lock.json checked in? Rust says that for libraries, versions should not be pinned, but for applications, they should. Does this conflict with the idea of having them in a shared workspace? (at the moment, game_controller_app has its own dependencies, but only because tauri cannot handle workspace dependencies in the latest released version)
  • Are the version specifications in Cargo.toml and package.json reasonable?

I usually don't write software in ecosystems where you add dependencies this way, so I have no idea what "the right thing" is.

@ahasselbring ahasselbring added this to the RoboCup 2023 milestone Apr 20, 2023
@ahasselbring ahasselbring removed this from the RoboCup 2023 milestone Jun 13, 2023
ahasselbring added a commit that referenced this issue Jun 14, 2023
as suggested by jayen
@jayenashar
Copy link
Collaborator

package.json isn't pinned. ^ means it can upgrade the patch level

@ahasselbring
Copy link
Member Author

According to the documentation, ^ can also upgrade minor (and ~ only patch level). The question is rather what we want.

If I understand it correctly, then for packages which can be trusted to use semver correctly (do those exist?), ~ would be okay (and ^ not necessary because if new features from a minor release are needed the version should be updated manually), while for packages without a strict version scheme we should pin an exact version?

@jayenashar
Copy link
Collaborator

^ is perfectly normal for node projects, so i think we should keep it. the package-lock says explicitly which versions are known to work

ahasselbring added a commit that referenced this issue Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants