Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "ModulationRangeMin" to "ModulationClipMin" #252

Open
elanhickler opened this issue Oct 23, 2018 · 0 comments
Open

Rename "ModulationRangeMin" to "ModulationClipMin" #252

elanhickler opened this issue Oct 23, 2018 · 0 comments

Comments

@elanhickler
Copy link
Contributor

elanhickler commented Oct 23, 2018

In your modulation target classes and whatever else uses this nomenclature, please rename Range to Clip.

Depth and Range are too similar and it confuses me every time to remember which one is the one that prevents the final modulation value from going too high or low (which could break the plugin)

Note to self: Range = clip / limit to the final modulation value
Depth = range / user control for amount of modulation

@elanhickler elanhickler changed the title Please rename "ModulationRangeMin" to "ModulationClipMin" Rename "ModulationRangeMin" to "ModulationClipMin" Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant